[PATCH] kunit: Add missing newline in summary message

[PATCH] kunit: Add missing newline in summary message

[Marco Elver]

Add missing newline, as otherwise flushing of the final summary message
to the console log can be delayed.

Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
Signed-off-by: Marco Elver <elver@google.com>
---
 lib/kunit/test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/kunit/test.c b/lib/kunit/test.c
index 7a6430a7fca0..ccb2ffad8dcf 100644
--- a/lib/kunit/test.c
+++ b/lib/kunit/test.c
@@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
 	 * representation.
 	 */
 	if (suite)
-		pr_info("%s %zd - %s",
+		pr_info("%s %zd - %s\n",
 			kunit_status_to_string(is_ok),
 			test_number, description);
 	else
-- 
2.26.1.301.g55bc3eb7cb9-goog

Re: [PATCH] kunit: Add missing newline in summary message

[David Gow]

On Thu, Apr 16, 2020 at 7:43 PM 'Marco Elver' via KUnit Development
<kunit-dev@googlegroups.com> wrote:
>
> Add missing newline, as otherwise flushing of the final summary message
> to the console log can be delayed.
>
> Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> Signed-off-by: Marco Elver <elver@google.com>

Tested-by: David Gow <davidgow@google.com>

Thanks a lot: this issue was starting to get annoying, and I can
confirm this patch fixes it for me!

-- David

Re: [PATCH] kunit: Add missing newline in summary message

[Alan Maguire]

On Thu, 16 Apr 2020, Marco Elver wrote:

> Add missing newline, as otherwise flushing of the final summary message
> to the console log can be delayed.
> 
> Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> Signed-off-by: Marco Elver <elver@google.com>

Reviewed-by: Alan Maguire <alan.maguire@oracle.com>

Thanks for finding/fixing this!

Alan

> ---
>  lib/kunit/test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> index 7a6430a7fca0..ccb2ffad8dcf 100644
> --- a/lib/kunit/test.c
> +++ b/lib/kunit/test.c
> @@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
>  	 * representation.
>  	 */
>  	if (suite)
> -		pr_info("%s %zd - %s",
> +		pr_info("%s %zd - %s\n",
>  			kunit_status_to_string(is_ok),
>  			test_number, description);
>  	else
> -- 
> 2.26.1.301.g55bc3eb7cb9-goog
> 
> 

Re: [PATCH] kunit: Add missing newline in summary message

[Marco Elver]

On Fri, 17 Apr 2020 at 12:03, Alan Maguire <alan.maguire@oracle.com> wrote:
>
> On Thu, 16 Apr 2020, Marco Elver wrote:
>
> > Add missing newline, as otherwise flushing of the final summary message
> > to the console log can be delayed.
> >
> > Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> > Signed-off-by: Marco Elver <elver@google.com>
>
> Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
>
> Thanks for finding/fixing this!
>
> Alan
>
> > ---
> >  lib/kunit/test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)

Which tree will pick this up? I cannot yet see this in -next.

Thanks,
-- Marco


> > diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> > index 7a6430a7fca0..ccb2ffad8dcf 100644
> > --- a/lib/kunit/test.c
> > +++ b/lib/kunit/test.c
> > @@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
> >        * representation.
> >        */
> >       if (suite)
> > -             pr_info("%s %zd - %s",
> > +             pr_info("%s %zd - %s\n",
> >                       kunit_status_to_string(is_ok),
> >                       test_number, description);
> >       else
> > --
> > 2.26.1.301.g55bc3eb7cb9-goog
> >
> >

Re: [PATCH] kunit: Add missing newline in summary message

[Brendan Higgins]

On Thu, Apr 16, 2020 at 4:43 AM Marco Elver <elver@google.com> wrote:
>
> Add missing newline, as otherwise flushing of the final summary message
> to the console log can be delayed.
>
> Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> Signed-off-by: Marco Elver <elver@google.com>

Acked-by: Brendan Higgins <brendanhiggins@google.com>

Thanks!

Re: [PATCH] kunit: Add missing newline in summary message

[Brendan Higgins]

On Wed, Apr 22, 2020 at 4:05 AM Marco Elver <elver@google.com> wrote:
>
> On Fri, 17 Apr 2020 at 12:03, Alan Maguire <alan.maguire@oracle.com> wrote:
> >
> > On Thu, 16 Apr 2020, Marco Elver wrote:
> >
> > > Add missing newline, as otherwise flushing of the final summary message
> > > to the console log can be delayed.
> > >
> > > Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> > > Signed-off-by: Marco Elver <elver@google.com>
> >
> > Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
> >
> > Thanks for finding/fixing this!
> >
> > Alan
> >
> > > ---
> > >  lib/kunit/test.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Which tree will pick this up? I cannot yet see this in -next.

This will be picked up by kselftest/kunit:

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=kunit

Re: [PATCH] kunit: Add missing newline in summary message

[Shuah Khan]

On 4/22/20 1:35 PM, Brendan Higgins wrote:
> On Thu, Apr 16, 2020 at 4:43 AM Marco Elver <elver@google.com> wrote:
>>
>> Add missing newline, as otherwise flushing of the final summary message
>> to the console log can be delayed.
>>
>> Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
>> Signed-off-by: Marco Elver <elver@google.com>
> 
> Acked-by: Brendan Higgins <brendanhiggins@google.com>
> 
> Thanks!
> 

Applied. Now in

git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest kunit
branch.

thanks,
-- Shuah