From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6812C5517A for ; Tue, 10 Nov 2020 06:56:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79D2A20674 for ; Tue, 10 Nov 2020 06:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731552AbgKJG4e (ORCPT ); Tue, 10 Nov 2020 01:56:34 -0500 Received: from namei.org ([65.99.196.166]:39896 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726849AbgKJG4e (ORCPT ); Tue, 10 Nov 2020 01:56:34 -0500 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id 0AA6uHwv009615; Tue, 10 Nov 2020 06:56:17 GMT Date: Tue, 10 Nov 2020 17:56:17 +1100 (AEDT) From: James Morris To: Casey Schaufler , Florian Westphal , Pablo Neira Ayuso , Jozsef Kadlecsik , Paul Moore cc: casey.schaufler@intel.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, Audit-ML , Kees Cook , John Johansen , Tetsuo Handa , Paul Moore , Stephen Smalley , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH v22 06/23] LSM: Use lsmblob in security_secid_to_secctx In-Reply-To: <20201105004924.11651-7-casey@schaufler-ca.com> Message-ID: References: <20201105004924.11651-1-casey@schaufler-ca.com> <20201105004924.11651-7-casey@schaufler-ca.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Nov 2020, Casey Schaufler wrote: > Change security_secid_to_secctx() to take a lsmblob as input > instead of a u32 secid. It will then call the LSM hooks > using the lsmblob element allocated for that module. The > callers have been updated as well. This allows for the > possibility that more than one module may be called upon > to translate a secid to a string, as can occur in the > audit code. > > Signed-off-by: Casey Schaufler > Cc: netdev@vger.kernel.org > Cc: linux-audit@redhat.com Ditto with this, + audit. Also, you should put primary maintainers on the To: line or they may miss the email. -- James Morris