linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Morris <jmorris@namei.org>
To: "Mickaël Salaün" <mic@digikod.net>, "Jann Horn" <jannh@google.com>
Cc: "Serge E . Hallyn" <serge@hallyn.com>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Andy Lutomirski" <luto@amacapital.net>,
	"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Casey Schaufler" <casey@schaufler-ca.com>,
	"Jann Horn" <jannh@google.com>, "Jeff Dike" <jdike@addtoit.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Kees Cook" <keescook@chromium.org>,
	"Michael Kerrisk" <mtk.manpages@gmail.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Shuah Khan" <shuah@kernel.org>,
	"Vincent Dagonneau" <vincent.dagonneau@ssi.gouv.fr>,
	kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org,
	linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	linux-security-module@vger.kernel.org, x86@kernel.org,
	"Mickaël Salaün" <mic@linux.microsoft.com>
Subject: Re: [PATCH v24 02/12] landlock: Add ruleset and domain management
Date: Fri, 20 Nov 2020 12:52:38 +1100 (AEDT)	[thread overview]
Message-ID: <alpine.LRH.2.21.2011201251010.15634@namei.org> (raw)
In-Reply-To: <20201112205141.775752-3-mic@digikod.net>

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Thu, 12 Nov 2020, Mickaël Salaün wrote:

> Cc: James Morris <jmorris@namei.org>
> Cc: Jann Horn <jannh@google.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Serge E. Hallyn <serge@hallyn.com>
> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
> ---
> 
> Changes since v23:
> * Always intersect access rights.  Following the filesystem change
>   logic, make ruleset updates more consistent by always intersecting
>   access rights (boolean AND) instead of combining them (boolean OR) for
>   the same layer.  This defensive approach could also help avoid user
>   space to inadvertently allow multiple access rights for the same
>   object (e.g.  write and execute access on a path hierarchy) instead of
>   dealing with such inconsistency.  This can happen when there is no
>   deduplication of objects (e.g. paths and underlying inodes) whereas
>   they get different access rights with landlock_add_rule(2).
> * Add extra checks to make sure that:
>   - there is always an (allocated) object in each used rules;
>   - when updating a ruleset with a new rule (i.e. not merging two
>     rulesets), the ruleset doesn't contain multiple layers.
> * Hide merge parameter from the public landlock_insert_rule() API.  This
>   helps avoid misuse of this function.
> * Replace a remaining hardcoded 1 with SINGLE_DEPTH_NESTING.

Jann: any chance you could review this patch again given the changes 
above?

Thanks.


-- 
James Morris
<jmorris@namei.org>

  reply	other threads:[~2020-11-20  1:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 20:51 [PATCH v24 00/12] Landlock LSM Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 01/12] landlock: Add object management Mickaël Salaün
2020-11-21  7:00   ` Jann Horn
2020-11-21 10:11     ` Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 02/12] landlock: Add ruleset and domain management Mickaël Salaün
2020-11-20  1:52   ` James Morris [this message]
2020-11-21  7:00   ` Jann Horn
2020-11-21  9:45     ` Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 03/12] landlock: Set up the security framework and manage credentials Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 04/12] landlock: Add ptrace restrictions Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 05/12] LSM: Infrastructure management of the superblock Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 06/12] fs,security: Add sb_delete hook Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 07/12] landlock: Support filesystem access-control Mickaël Salaün
2020-11-21  7:00   ` Jann Horn
2020-11-21 10:06     ` Mickaël Salaün
2020-11-23 19:44       ` Jann Horn
2020-11-23 21:16         ` Mickaël Salaün
2020-11-23 21:19           ` Jann Horn
2020-11-12 20:51 ` [PATCH v24 08/12] landlock: Add syscall implementations Mickaël Salaün
2020-11-21  7:00   ` Jann Horn
2020-11-12 20:51 ` [PATCH v24 09/12] arch: Wire up Landlock syscalls Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 10/12] selftests/landlock: Add user space tests Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 11/12] samples/landlock: Add a sandbox manager example Mickaël Salaün
2020-11-12 20:51 ` [PATCH v24 12/12] landlock: Add user and kernel documentation Mickaël Salaün
2020-11-21  7:00   ` Jann Horn
2020-11-24  2:38     ` James Morris
2020-11-17  5:37 ` [PATCH v24 00/12] Landlock LSM James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.21.2011201251010.15634@namei.org \
    --to=jmorris@namei.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=arnd@arndb.de \
    --cc=casey@schaufler-ca.com \
    --cc=corbet@lwn.net \
    --cc=jannh@google.com \
    --cc=jdike@addtoit.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mic@digikod.net \
    --cc=mic@linux.microsoft.com \
    --cc=mtk.manpages@gmail.com \
    --cc=richard@nod.at \
    --cc=serge@hallyn.com \
    --cc=shuah@kernel.org \
    --cc=vincent.dagonneau@ssi.gouv.fr \
    --cc=viro@zeniv.linux.org.uk \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH v24 02/12] landlock: Add ruleset and domain management' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).