From: Jan Engelhardt <jengelh@medozas.de>
To: "André Goddard Rosa" <andre.goddard@gmail.com>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@hansenpartnership.com
Subject: Re: [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available
Date: Sun, 8 Nov 2009 17:56:37 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.00.0911081755500.30674@obet.zrqbmnf.qr> (raw)
In-Reply-To: <c7d3b02b5e28eaa54a5360d57dfd177c44320187.1257602781.git.andre.goddard@gmail.com>
On Saturday 2009-11-07 17:30, André Goddard Rosa wrote:
>+char *skip_spaces(const char *str)
>@@ -352,10 +366,7 @@ char *strstrip(char *s)
> end--;
> *(end + 1) = '\0';
>
>- while (*s && isspace(*s))
>- s++;
>-
>- return s;
>+ return (char *)skip_spaces(s);
> }
sparse would probably say "how much more casting to the same type do you want?"
It is already char*.
next prev parent reply other threads:[~2009-11-08 16:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1257602781.git.andre.goddard@gmail.com>
2009-11-07 16:23 ` [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available André Goddard Rosa
2009-11-08 15:54 ` Jan Engelhardt
2009-11-08 16:38 ` James Bottomley
2009-11-08 16:54 ` Jan Engelhardt
2009-11-08 16:59 ` André Goddard Rosa
2009-11-08 16:56 ` Jan Engelhardt [this message]
[not found] ` <20091108165000.374714cb@lxorguk.ukuu.org.uk>
2009-11-09 14:02 ` André Goddard Rosa
2009-11-07 16:33 ` [PATCH v4 08/12] vsprintf: reuse almost identical simple_strtoulX() functions André Goddard Rosa
[not found] ` <643e6260a571b533d8985b377a82410aded4ddae.1257602781.git.andre.goddard@gmail.com>
2009-11-08 15:37 ` [PATCH v4 01/12] vsprintf: factorize "(null)" string Jan Engelhardt
2009-11-08 15:49 ` André Goddard Rosa
2009-11-09 3:28 ` Rusty Russell
2009-11-10 14:33 ` André Goddard Rosa
[not found] ` <7206ef594e67a240a842339f520284de6569b1fc.1257602781.git.andre.goddard@gmail.com>
2009-11-08 15:44 ` [PATCH v4 07/12] vsprintf: factor out skip_space code in a separate function Jan Engelhardt
2009-11-08 15:52 ` André Goddard Rosa
[not found] ` <31525.1257770343@redhat.com>
2009-11-09 15:31 ` André Goddard Rosa
[not found] ` <1257696303.4184.8.camel@mulgrave.site>
[not found] ` <b8bf37780911080852l10d11f4ele5bf6a6aed94c5fe@mail.gmail.com>
2009-11-08 16:55 ` [dm-devel] [PATCH v4 00/12] introduce skip_spaces(), reducing code size plus some clean-ups Jan Engelhardt
2009-11-08 17:02 ` Alexey Dobriyan
[not found] ` <7d5883637aa976b54e944998f635d47a41618a75.1257602781.git.andre.goddard@gmail.com>
2009-11-14 4:20 ` [ibm-acpi-devel] [PATCH v4 12/12] tree-wide: convert open calls to remove spaces to skip_spaces() lib function Henrique de Moraes Holschuh
2009-11-14 7:44 ` André Goddard Rosa
[not found] ` <20091108184722.GA1647@mit.edu>
[not found] ` <Pine.LNX.4.64.0911082103000.8143@ask.diku.dk>
2009-11-15 6:19 ` André Goddard Rosa
2009-11-15 6:37 ` André Goddard Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.0911081755500.30674@obet.zrqbmnf.qr \
--to=jengelh@medozas.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andre.goddard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).