From: Hugh Dickins <hughd@google.com>
To: Cong Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Pekka Enberg <penberg@kernel.org>, Christoph Hellwig <hch@lst.de>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Lennart Poettering <lennart@poettering.net>,
Kay Sievers <kay.sievers@vrfy.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [V3 PATCH 1/2] tmpfs: add fallocate support
Date: Wed, 23 Nov 2011 11:07:05 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.00.1111231100110.2226@sister.anvils> (raw)
In-Reply-To: <1322038412-29013-1-git-send-email-amwang@redhat.com>
On Wed, 23 Nov 2011, Cong Wang wrote:
> +
> + while (index < end) {
> + ret = shmem_getpage(inode, index, &page, SGP_WRITE, NULL);
> + if (ret) {
> + if (ret == -ENOSPC)
> + goto undo;
...
> +undo:
> + while (index > start) {
> + shmem_truncate_page(inode, index);
> + index--;
> + }
As I said before, I won't actually be reviewing and testing this for
a week or two; but before this goes any further, must point out how
wrong it is. Here you'll be deleting any pages in the range that were
already present before the failing fallocate().
Hugh
next prev parent reply other threads:[~2011-11-23 19:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 8:53 [V3 PATCH 1/2] tmpfs: add fallocate support Cong Wang
2011-11-23 8:53 ` [PATCH 2/2] fs: wire up .truncate_range and .fallocate Cong Wang
2011-11-23 10:38 ` Christoph Hellwig
2011-11-23 19:16 ` Hugh Dickins
2011-11-23 9:06 ` [V3 PATCH 1/2] tmpfs: add fallocate support Pekka Enberg
2011-11-23 19:07 ` Hugh Dickins [this message]
2011-11-24 3:18 ` Cong Wang
2011-11-23 19:59 ` KOSAKI Motohiro
2011-11-23 21:11 ` Pekka Enberg
2011-11-23 22:20 ` Hugh Dickins
2011-11-24 3:15 ` Cong Wang
2011-11-24 1:52 ` KAMEZAWA Hiroyuki
2011-11-24 2:46 ` KOSAKI Motohiro
2011-11-24 3:01 ` KAMEZAWA Hiroyuki
2011-11-24 3:22 ` Cong Wang
2011-11-24 4:23 ` KAMEZAWA Hiroyuki
2011-11-24 5:52 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1111231100110.2226@sister.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=kay.sievers@vrfy.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).