From: Hugh Dickins <hughd@google.com>
To: aris@redhat.com
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Li Zefan <lizefan@huawei.com>, Tejun Heo <tj@kernel.org>,
Hugh Dickins <hughd@google.com>, Hillf Danton <dhillf@gmail.com>,
Lennart Poettering <lpoetter@redhat.com>
Subject: Re: [PATCH v7 1/4] xattr: extract simple_xattr code from tmpfs
Date: Thu, 23 Aug 2012 16:14:24 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.00.1208231609240.5904@eggly.anvils> (raw)
In-Reply-To: <20120823205327.613311683@napanee.usersys.redhat.com>
On Thu, 23 Aug 2012, aris@redhat.com wrote:
> From: Li Zefan <lizefan@huawei.com>
>
> Extract in-memory xattr APIs from tmpfs. Will be used by cgroup.
>
> $ size vmlinux.o
> text data bss dec hex filename
> 4658782 880729 5195032 10734543 a3cbcf vmlinux.o
> $ size vmlinux.o
> text data bss dec hex filename
> 4658957 880729 5195032 10734718 a3cc7e vmlinux.o
>
> v7:
> - checkpatch warnings fixed
> - Implement the changes requested by Hugh Dickins:
> - make simple_xattrs_init and simple_xattrs_free inline
> - get rid of locking and list reinitialization in simple_xattrs_free,
> they're not needed
Thanks for doing those.
I'm also happy to see that you're now using simple_xattr_alloc() in
__simple_xattr_set() (but no need to respin to comment on that here).
It looks very nice: much better for this code to live in fs/xattr.c
than in mm/shmem.c.
> v6:
> - no changes
> v5:
> - no changes
> v4:
> - move simple_xattrs_free() to fs/xattr.c
> v3:
> - in kmem_xattrs_free(), reinitialize the list
> - use simple_xattr_* prefix
> - introduce simple_xattr_add() to prevent direct list usage
>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Hugh Dickins <hughd@google.com>
Acked-by: Hugh Dickins <hughd@google.com>
> Cc: Hillf Danton <dhillf@gmail.com>
> Cc: Lennart Poettering <lpoetter@redhat.com>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
next prev parent reply other threads:[~2012-08-23 23:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 20:53 [PATCH v7 0/4] cgroup: add xattr support aris
2012-08-23 20:53 ` [PATCH v7 1/4] xattr: extract simple_xattr code from tmpfs aris
2012-08-23 23:14 ` Hugh Dickins [this message]
2012-08-24 13:14 ` Aristeu Rozanski
2012-08-23 20:53 ` [PATCH v7 2/4] cgroup: revise how we re-populate root directory aris
2012-08-23 20:53 ` [PATCH v7 3/4] cgroup: add xattr support aris
2012-08-23 20:53 ` [PATCH v7 4/4] cgroup: rename subsys_bits to subsys_mask aris
2012-08-24 22:58 ` [PATCH v7 0/4] cgroup: add xattr support Tejun Heo
2012-08-27 13:05 ` Aristeu Rozanski
2012-08-28 16:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1208231609240.5904@eggly.anvils \
--to=hughd@google.com \
--cc=aris@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=lpoetter@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).