From: Jan Engelhardt <jengelh@medozas.de>
To: Patrick McHardy <kaber@trash.net>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Randy Dunlap <randy.dunlap@oracle.com>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
herbert@gondor.hengli.com.au
Subject: Re: several messages
Date: Thu, 15 Jul 2010 12:17:46 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.01.1007151216170.19772@obet.zrqbmnf.qr> (raw)
In-Reply-To: <4C3ED764.3060301@trash.net>
On Thursday 2010-07-15 11:36, Patrick McHardy wrote:
>> +struct xt_CHECKSUM_info {
>> + u_int8_t operation; /* bitset of operations */
>
>Please use __u8 in public header files.
>
>> +#include <linux/in.h>
>
>Do you really need in.h?
>
>> + * $Id$
>
>Please no CVS IDs.
>
>> + switch (c) {
>> + case 'F':
>> + if (*flags)
>> + xtables_error(PARAMETER_PROBLEM,
>> + "CHECKSUM target: Only use --checksum-fill ONCE!");
>
>There is a helper function called xtables_param_act for checking double
>arguments and printing a standarized error message.
I took care of these for Xt-a.
next prev parent reply other threads:[~2010-07-15 10:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 15:06 [PATCHv2] netfilter: add CHECKSUM target Michael S. Tsirkin
2010-07-11 15:08 ` [PATCHv2] extensions: libxt_CHECKSUM extension Michael S. Tsirkin
2010-07-11 15:14 ` [PATCHv3] " Michael S. Tsirkin
2010-07-15 9:39 ` Patrick McHardy
2010-07-15 10:17 ` Jan Engelhardt [this message]
2010-07-15 9:36 ` [PATCHv2] netfilter: add CHECKSUM target Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2016-01-25 18:37 [PATCH v2 0/3] x86/mm: INVPCID support Andy Lutomirski
2016-01-25 18:57 ` Ingo Molnar
2016-01-27 10:09 ` several messages Thomas Gleixner
2016-01-29 13:21 ` Borislav Petkov
2014-11-10 6:26 [PATCH 00/13] Add VT-d Posted-Interrupts support for KVM Feng Wu
2014-11-10 6:26 ` [PATCH 13/13] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu
2014-11-10 18:15 ` several messages Thomas Gleixner
2014-11-11 2:28 ` Jiang Liu
2014-11-11 6:37 ` Wu, Feng
2008-11-26 14:33 [PATCH 0/1] HID: hid_apple is not used for apple alu wireless keyboards Jan Scholz
2008-11-26 14:33 ` [PATCH 1/1] HID: Apple alu wireless keyboards are bluetooth devices Jan Scholz
2008-11-26 14:54 ` Jiri Kosina
2008-11-26 15:17 ` Jan Scholz
2008-11-26 15:33 ` Jiri Kosina
2008-11-26 21:06 ` Tobias Müller
2008-11-27 0:57 ` several messages Jiri Kosina
2008-10-19 14:15 [PATCH 1/2] HID: add hid_type Jiri Slaby
2008-10-19 14:15 ` [PATCH 2/2] HID: fix appletouch regression Jiri Slaby
2008-10-19 19:40 ` several messages Jiri Kosina
2008-10-19 20:06 ` Justin Mattock
2008-10-19 22:09 ` Jiri Slaby
[not found] <200702211929.17203.david-b@pacbell.net>
2007-02-22 3:50 ` [patch 6/6] rtc suspend()/resume() restores system clock David Brownell
2007-02-22 22:58 ` several messages Guennadi Liakhovetski
2007-02-23 1:15 ` David Brownell
2007-02-23 11:17 ` Johannes Berg
2006-04-11 17:33 Linux 2.6.16.4 Greg KH
2006-04-11 19:04 ` several messages Jan Engelhardt
2006-04-11 19:20 ` Boris B. Zhmurov
2006-04-11 20:30 ` Greg KH
2006-04-11 23:46 ` Jan Engelhardt
2006-04-12 0:36 ` Nix
2005-05-04 17:31 ata over ethernet question Maciej Soltysiak
2005-05-04 19:48 ` David Hollis
2005-05-04 21:17 ` Re[2]: " Maciej Soltysiak
2005-05-05 15:09 ` David Hollis
2005-05-07 15:05 ` Sander
2005-05-10 22:00 ` Guennadi Liakhovetski
2005-05-11 8:56 ` Vladislav Bolkhovitin
2005-05-11 21:26 ` several messages Guennadi Liakhovetski
2005-05-12 2:16 ` Ming Zhang
2005-05-12 18:32 ` Dmitry Yusupov
2005-05-13 8:12 ` Christoph Hellwig
2005-05-13 15:04 ` Dmitry Yusupov
2005-05-13 15:07 ` Christoph Hellwig
2005-05-13 15:38 ` Dmitry Yusupov
2005-05-12 10:17 ` Vladislav Bolkhovitin
2004-05-11 8:45 2.6.6-rc3-mm2 (4KSTACK) Helge Hafting
2004-05-11 17:59 ` several messages Bill Davidsen
2003-04-22 10:34 [patch] HT scheduler, sched-2.5.68-A9 Ingo Molnar
2003-04-22 22:16 ` several messages Bill Davidsen
2003-04-22 23:38 ` Rick Lindsley
2003-04-23 9:17 ` Ingo Molnar
2003-01-23 0:20 ANN: LKMB (Linux Kernel Module Builder) version 0.1.16 Hal Duston
2003-01-27 16:46 ` several messages Bill Davidsen
2003-01-27 16:59 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.01.1007151216170.19772@obet.zrqbmnf.qr \
--to=jengelh@medozas.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=kaber@trash.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).