From: Hugh Dickins <hughd@google.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: Hugh Dickins <hughd@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
"Shishkin, Alexander" <alexander.shishkin@intel.com>,
"Kleen, Andi" <andi.kleen@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephane Eranian <eranian@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [bug] kpti, perf_event, bts: sporadic truncated trace
Date: Fri, 13 Jul 2018 11:31:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.11.1807131111440.6085@eggly.anvils> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B236B3308EE@IRSMSX104.ger.corp.intel.com>
On Fri, 13 Jul 2018, Metzger, Markus T wrote:
> Hello Hugh,
>
> > A little "optimization" crept into alloc_bts_buffer() along the way, which now
> > places bts_interrupt_threshold not on a record boundary.
> > And Stephane has shown me the sentence in Vol 3B, 17.4.9, which says "This
> > address must point to an offset from the BTS buffer base that is a multiple of the
> > BTS record size."
> >
> > Please give the patch below a try, and let us know if it helps (if it does not, then I
> > think we'll need perfier expertise than I can give).
> >
> > Hugh
> >
> > --- 4.18-rc4/arch/x86/events/intel/ds.c 2018-06-03 14:15:21.000000000 -0700
> > +++ linux/arch/x86/events/intel/ds.c 2018-07-12 17:38:28.471378616 -0700
> > @@ -408,9 +408,11 @@ static int alloc_bts_buffer(int cpu)
> > ds->bts_buffer_base = (unsigned long) cea;
> > ds_update_cea(cea, buffer, BTS_BUFFER_SIZE, PAGE_KERNEL);
> > ds->bts_index = ds->bts_buffer_base;
> > - max = BTS_RECORD_SIZE * (BTS_BUFFER_SIZE / BTS_RECORD_SIZE);
> > - ds->bts_absolute_maximum = ds->bts_buffer_base + max;
> > - ds->bts_interrupt_threshold = ds->bts_absolute_maximum - (max / 16);
> > + max = BTS_BUFFER_SIZE / BTS_RECORD_SIZE;
> > + ds->bts_absolute_maximum = ds->bts_buffer_base +
> > + max * BTS_RECORD_SIZE;
> > + ds->bts_interrupt_threshold = ds->bts_absolute_maximum -
> > + (max / 16) * BTS_RECORD_SIZE;
> > return 0;
> > }
> >
>
> Your patch fixes it.
Oh, very welcome news! Thanks for putting in all the effort you did to
track down from your end: I'm relieved it was easier to fix than that.
>
> Will you send it to the list for inclusion?
Sure, I'll send to x86 guys and lkml later today. I can't promise that
it will make 4.18, since the regression it fixes pre-dates 4.18-rc; but
they don't usually insist on that rule for something as small and benign
as this, so I expect it'll make it.
> I'd appreciate if it could also be backported
> to 4.15, 4.16, and 4.17.
I'll mark it Cc stable, so that it will soon percolate through to the
4.14 longterm and 4.17 stable trees. But 4.15 and 4.16 stable trees are
now EOL, so you'll have to apply the patch where you need it yourself -
it has no release-dependent subtlety, it should apply cleanly at offset.
Hugh
next prev parent reply other threads:[~2018-07-13 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 10:15 [bug] kpti, perf_event, bts: sporadic truncated trace Metzger, Markus T
2018-07-12 14:01 ` Andi Kleen
2018-07-13 1:22 ` Hugh Dickins
2018-07-13 10:06 ` Metzger, Markus T
2018-07-13 18:31 ` Hugh Dickins [this message]
2018-07-13 10:53 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1807131111440.6085@eggly.anvils \
--to=hughd@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@intel.com \
--cc=andi.kleen@intel.com \
--cc=dave.hansen@intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).