From: Hugh Dickins <hughd@google.com>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Michal Hocko <mhocko@suse.com>,
Vlastimil Babka <vbabka@suse.cz>,
Andrea Arcangeli <aarcange@redhat.com>,
David Hildenbrand <david@redhat.com>,
Mel Gorman <mgorman@techsingularity.net>,
David Herrmann <dh.herrmann@gmail.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Kan Liang <kan.liang@intel.com>, Andi Kleen <ak@linux.intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Peter Zijlstra <peterz@infradead.org>,
Christoph Lameter <cl@linux.com>, Nick Piggin <npiggin@gmail.com>,
pifang@redhat.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCHi v2] mm: put_and_wait_on_page_locked() while page is migrated
Date: Tue, 27 Nov 2018 13:08:50 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.1811271258070.4506@eggly.anvils> (raw)
In-Reply-To: <20181127105848.GD16502@rapoport-lnx>
On Tue, 27 Nov 2018, Mike Rapoport wrote:
> On Mon, Nov 26, 2018 at 11:27:07AM -0800, Hugh Dickins wrote:
> >
> > +/*
> > + * A choice of three behaviors for wait_on_page_bit_common():
> > + */
> > +enum behavior {
> > + EXCLUSIVE, /* Hold ref to page and take the bit when woken, like
> > + * __lock_page() waiting on then setting PG_locked.
> > + */
> > + SHARED, /* Hold ref to page and check the bit when woken, like
> > + * wait_on_page_writeback() waiting on PG_writeback.
> > + */
> > + DROP, /* Drop ref to page before wait, no check when woken,
> > + * like put_and_wait_on_page_locked() on PG_locked.
> > + */
> > +};
>
> Can we please make it:
>
> /**
> * enum behavior - a choice of three behaviors for wait_on_page_bit_common()
> */
> enum behavior {
> /**
> * @EXCLUSIVE: Hold ref to page and take the bit when woken,
> * like __lock_page() waiting on then setting %PG_locked.
> */
> EXCLUSIVE,
> /**
> * @SHARED: Hold ref to page and check the bit when woken,
> * like wait_on_page_writeback() waiting on %PG_writeback.
> */
> SHARED,
> /**
> * @DROP: Drop ref to page before wait, no check when woken,
> * like put_and_wait_on_page_locked() on %PG_locked.
> */
> DROP,
> };
I'm with Matthew, I'd prefer not: the first looks a more readable,
less cluttered comment to me than the second: this is just an arg
to an internal helper in mm/filemap.c, itself not kernel-doc'ed.
But the comment is not there for me: if consensus is that the
second is preferable, then sure, we can change it over.
Hugh
next prev parent reply other threads:[~2018-11-27 21:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 3:21 [PATCH] mm: put_and_wait_on_page_locked() while page is migrated Hugh Dickins
2018-11-25 4:07 ` Andrea Arcangeli
2018-11-25 18:30 ` Linus Torvalds
2018-11-26 3:29 ` Hugh Dickins
2018-11-26 19:27 ` Tim Chen
2018-11-26 19:27 ` [PATCHi v2] " Hugh Dickins
2018-11-26 19:30 ` Linus Torvalds
2018-11-26 19:53 ` Michal Hocko
2018-11-26 20:53 ` Matthew Wilcox
2018-11-27 10:56 ` Mike Rapoport
2018-11-27 16:49 ` Christopher Lameter
2018-11-27 16:56 ` Michal Hocko
2018-11-27 16:58 ` Linus Torvalds
2018-11-27 8:21 ` Vlastimil Babka
2018-11-27 10:58 ` Mike Rapoport
2018-11-27 18:10 ` Matthew Wilcox
2018-11-27 21:08 ` Hugh Dickins [this message]
2018-11-27 21:45 ` Mike Rapoport
2018-11-27 22:40 ` Joey Pabalinas
2019-01-10 9:26 ` Vlastimil Babka
2019-01-11 2:08 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1811271258070.4506@eggly.anvils \
--to=hughd@google.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=cl@linux.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=dh.herrmann@gmail.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=pifang@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).