From: Hugh Dickins <hughd@google.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
hughd@google.com, linux-leds@vger.kernel.org,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: leds: avoid flush_work in atomic context
Date: Sun, 26 May 2019 12:34:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.11.1905261226040.2004@eggly.anvils> (raw)
In-Reply-To: <20190526173700.GD1282@xo-6d-61-c0.localdomain>
On Sun, 26 May 2019, Pavel Machek wrote:
> Hi!
>
> > Thank you for the patch.
> >
> > I've applied it however I'm not sure if it is an official
> > submission, since it doesn't look like (no [PATCH] tag
> > in the subject).
>
> It was official submission :-).
>
> > Beside that 'Fixes' tag is somewhat incomplete - it should be
> > generated using following git command:
> >
> > git log -1 0db37915d912 --format='Fixes: %h ("%s")'
> >
> > Fixed that and applied to the for-next branch and will push
> > it upstream after a bit of testing for rc3 or rc4.
>
> Ok. Note that this did not crash Hugh's machine but it may crash
> someone else's, and probably crashed mine already.
Where "this" is commit 0db37915d912, I hope: right, it did not
actually crash my machine, but the splurge of warning messages
forced me to reboot quickly, and go look for the culprit.
Your fix certainly did not crash my machine either,
but I hope we don't expect your fix to crash someone else's!
>
> So... it makes sense to push it to Linus "soon".
Agreed.
Hugh
prev parent reply other threads:[~2019-05-26 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 7:38 leds: avoid flush_work in atomic context Pavel Machek
2019-05-26 16:57 ` Jacek Anaszewski
2019-05-26 17:37 ` Pavel Machek
2019-05-26 19:34 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1905261226040.2004@eggly.anvils \
--to=hughd@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).