From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A61C433DB for ; Mon, 8 Feb 2021 22:52:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F395C64E7A for ; Mon, 8 Feb 2021 22:52:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbhBHWvy (ORCPT ); Mon, 8 Feb 2021 17:51:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbhBHWvn (ORCPT ); Mon, 8 Feb 2021 17:51:43 -0500 Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EF67C06178B for ; Mon, 8 Feb 2021 14:51:03 -0800 (PST) Received: by mail-oo1-xc2d.google.com with SMTP id x19so3829403ooj.10 for ; Mon, 08 Feb 2021 14:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2jaIFVPMabgNRI/gSMsENX64xR0X2GpzOOyOdGUnNRo=; b=pBScR02E5r0TkgIM7R/gTKUoLt7Z0j2l+KmGEUVvzVD6iJ+rV1NRqIGbxRSCpN/xF9 6ECzsWEtkMBYUHsLOW6EmRZvwcz50tmS4Z4kiMiTfHKdQVnDJR9wum99SFr67PJhCEhZ LIAGh6+XAHdhQB9YQkWu+PZsyD1WTPyCGPQIOOzymGPNz3Zg/acuqdTbeBlHqgHqbB9X QenXmEk9IGatt+KNlyRpsbxQe1sY+gcou4x4VQREJS7Wkxn/y9p8kt/wMxSfTAPAzsFj ohqYM+FW7JqUugev+5lDjtz30gnXn9A1GT2uGo8yxHk2lR3kD335idp9Ai8G83c7Ni6B LKbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2jaIFVPMabgNRI/gSMsENX64xR0X2GpzOOyOdGUnNRo=; b=qZu8YpNDI9qJoLiyPyNCIdKZt0nYucbg5xWLsqfe3OtY62wQ49Q+bFetKMB4FTdKBK YybzXUhZlb1oga7Qzlc1zBFBkZkum5vGrFsnYgUrfsiJUJRxvV6o5wXn1hqlLnRTNFKq Np5VxoohHaYUiq4wSNV//3CsOAPZHDv8BBOnipMR/fUBI0cQjOinSvvRff0HNDs7mGJa MDb8GKED0k3Rl3snukBdWyKL/cLTlDRI/NmU0MVO/YCjzDnoYBcaGqdWmr9feISPppjF WTAWWDlIojQ3P+yma3cBaa7DNKpJ/6O3XZ6TXi0mkJoDs71M+XoJU4K/wR4BQxBhZSk+ MSIg== X-Gm-Message-State: AOAM530/xQ9aUvcC4o0ZIXk3cSo2eQ3xwhHaKmi947PYye/xVKBrtLm5 q+HVonFdzuyOI41rrUYvlzsnyg== X-Google-Smtp-Source: ABdhPJwKMs+R/f6Grt4JROunZj+IRHTQeNwBZcyQQGNO0b5W18rmchqi31uaPJUE+MthD6a4Uan95Q== X-Received: by 2002:a4a:870c:: with SMTP id z12mr13898102ooh.15.1612824662639; Mon, 08 Feb 2021 14:51:02 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id r25sm1079478ota.42.2021.02.08.14.50.59 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 08 Feb 2021 14:51:01 -0800 (PST) Date: Mon, 8 Feb 2021 14:50:47 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Seth Forshee cc: Andrew Morton , Hugh Dickins , Chris Down , Amir Goldstein , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390 In-Reply-To: <20210205160551.cf57c4293ba5ccb8eb648c11@linux-foundation.org> Message-ID: References: <20210205230620.518245-1-seth.forshee@canonical.com> <20210205160551.cf57c4293ba5ccb8eb648c11@linux-foundation.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Feb 2021, Andrew Morton wrote: > On Fri, 5 Feb 2021 17:06:20 -0600 Seth Forshee wrote: > > > This feature requires ino_t be 64-bits, which is true for every > > 64-bit architecture but s390, so prevent this option from being > > selected there. > > > > The previous patch nicely described the end-user impact of the bug. > This is especially important when requesting a -stable backport. > > Here's what I ended up with: > > > From: Seth Forshee > Subject: tmpfs: disallow CONFIG_TMPFS_INODE64 on s390 > > Currently there is an assumption in tmpfs that 64-bit architectures also > have a 64-bit ino_t. This is not true on s390 which has a 32-bit ino_t. > With CONFIG_TMPFS_INODE64=y tmpfs mounts will get 64-bit inode numbers and > display "inode64" in the mount options, but passing the "inode64" mount > option will fail. This leads to the following behavior: > > # mkdir mnt > # mount -t tmpfs nodev mnt > # mount -o remount,rw mnt > mount: /home/ubuntu/mnt: mount point not mounted or bad option. > > As mount sees "inode64" in the mount options and thus passes it in the > options for the remount. > > > So prevent CONFIG_TMPFS_INODE64 from being selected on s390. > > Link: https://lkml.kernel.org/r/20210205230620.518245-1-seth.forshee@canonical.com > Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb") > Signed-off-by: Seth Forshee > Cc: Chris Down > Cc: Hugh Dickins Thank you Seth: now that you've fixed Kirill's alpha observation too, Acked-by: Hugh Dickins > Cc: Amir Goldstein > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc: [5.9+] > Signed-off-by: Andrew Morton > --- > > fs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/fs/Kconfig~tmpfs-disallow-config_tmpfs_inode64-on-s390 > +++ a/fs/Kconfig > @@ -203,7 +203,7 @@ config TMPFS_XATTR > > config TMPFS_INODE64 > bool "Use 64-bit ino_t by default in tmpfs" > - depends on TMPFS && 64BIT > + depends on TMPFS && 64BIT && !S390 > default n > help > tmpfs has historically used only inode numbers as wide as an unsigned > _ > >