From: Jiri Kosina <jikos@kernel.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, srinivas.pandruvada@linux.intel.com,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: constify device_type structure
Date: Tue, 14 Feb 2017 15:33:32 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1702141533040.24579@cbobk.fhfr.pm> (raw)
In-Reply-To: <1486797037-31415-1-git-send-email-bhumirks@gmail.com>
On Sat, 11 Feb 2017, Bhumika Goyal wrote:
> Declare device_type structure as const as it is only stored in the
> type field of a device structure. This field is of type const, so add
> const to the declaration of device_type structure.
>
> File size before: drivers/hid/intel-ish-hid/ishtp/bus.o
> text data bss dec hex filename
> 4260 336 16 4612 1204 hid/intel-ish-hid/ishtp/bus.o
>
> File size after: drivers/hid/intel-ish-hid/ishtp/bus.o
> text data bss dec hex filename
> 4324 272 16 4612 1204 hid/intel-ish-hid/ishtp/bus.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index f4cbc74..5f382fe 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -358,7 +358,7 @@ static void ishtp_cl_dev_release(struct device *dev)
> kfree(to_ishtp_cl_device(dev));
> }
>
> -static struct device_type ishtp_cl_device_type = {
> +static const struct device_type ishtp_cl_device_type = {
> .release = ishtp_cl_dev_release,
> };
Applied to hid.git#for-4.11/intel-ish, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2017-02-14 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 7:10 [PATCH] HID: intel-ish-hid: constify device_type structure Bhumika Goyal
2017-02-11 9:39 ` Srinivas Pandruvada
2017-02-14 14:33 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1702141533040.24579@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).