From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753664AbdEENcM (ORCPT ); Fri, 5 May 2017 09:32:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:53348 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752297AbdEENcL (ORCPT ); Fri, 5 May 2017 09:32:11 -0400 Date: Fri, 5 May 2017 15:32:09 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Thierry Escande cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: magicmouse: Set multi-touch keybits for Magic Mouse In-Reply-To: <1491552756-9933-1-git-send-email-thierry.escande@collabora.com> Message-ID: References: <1491552756-9933-1-git-send-email-thierry.escande@collabora.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Apr 2017, Thierry Escande wrote: > From: Che-Liang Chiou > > The driver emits multi-touch events for Magic Trackpad as well as Magic > Mouse, but it does not set keybits that are related to multi-touch event > for Magic Mouse; so set these keybits. > > The keybits that are not set cause trouble because user programs often > probe these keybits for self-configuration and thus they cannot operate > properly if the keybits are not set. > > One of such troubles is that libevdev will not be able to emit correct > touch count, causing gestures library failed to do fling stop. > > Signed-off-by: Che-Liang Chiou > Signed-off-by: Thierry Escande Applied to for-4.12/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs