linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miroslav Benes <mbenes@suse.cz>
To: Oleg Nesterov <oleg@redhat.com>
Cc: jpoimboe@redhat.com, jeyu@redhat.com, jikos@kernel.org,
	pmladek@suse.com, live-patching@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] livepatch: send a fake signal to all blocking tasks
Date: Fri, 19 May 2017 09:51:48 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LSU.2.20.1705190950440.31456@pobox.suse.cz> (raw)
In-Reply-To: <20170518195255.GA2518@redhat.com>


> > If not, we get back to exit_to_usermode_loop() and TIF_PATCH_PENDING is 
> > cleared. Yes, it is true that TIF_SIGPENDING is still set and we get to
> > do_signal() once more. But for the last time.
> 
> Yes, slightly sub-optimal but not really wrong and you can swap
> do_signal() and klp_update_patch_state().

Ok. I'll add it to v2.
 
> > If the syscall is restarted, it may be different. I have to think about
> > this one. But...
> 
> Afaics, there are no problems.
> 
> 
> In short. Thanks for correcting me and sorry for noise!

Thanks for the review, Oleg. Much appreciated.

Miroslav

  reply	other threads:[~2017-05-19  7:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 12:00 [PATCH 0/3] livepatch: Introduce force sysfs attribute Miroslav Benes
2017-05-18 12:00 ` [PATCH 1/3] livepatch: Add " Miroslav Benes
2017-05-18 13:05   ` Libor Pechacek
2017-05-18 13:20     ` Miroslav Benes
2017-05-18 12:00 ` [PATCH 2/3] livepatch: send a fake signal to all blocking tasks Miroslav Benes
2017-05-18 13:10   ` Libor Pechacek
2017-05-18 13:20     ` Miroslav Benes
2017-05-18 16:49   ` Oleg Nesterov
2017-05-18 18:14     ` Miroslav Benes
2017-05-18 19:52       ` Oleg Nesterov
2017-05-19  7:51         ` Miroslav Benes [this message]
2017-05-23 17:30   ` Josh Poimboeuf
2017-05-24  8:31     ` Miroslav Benes
2017-05-18 12:00 ` [PATCH 3/3] livepatch: force transition process to finish Miroslav Benes
2017-05-18 13:16   ` Libor Pechacek
2017-05-18 13:22     ` Miroslav Benes
2017-05-23 17:27   ` Josh Poimboeuf
2017-05-24  8:36     ` Miroslav Benes
2017-05-24 13:06   ` Petr Mladek
2017-05-24 14:15     ` Miroslav Benes
2017-05-24 15:09       ` Petr Mladek
2017-05-25 12:59         ` Miroslav Benes
2017-05-25 16:03           ` Petr Mladek
2017-05-26 17:37             ` Josh Poimboeuf
2017-05-29 12:28               ` Petr Mladek
2017-05-30 12:41                 ` Josh Poimboeuf
2017-05-26 17:38   ` Josh Poimboeuf
2017-05-29  9:26     ` Miroslav Benes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.20.1705190950440.31456@pobox.suse.cz \
    --to=mbenes@suse.cz \
    --cc=jeyu@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).