From: Miroslav Benes <mbenes@suse.cz>
To: Petr Mladek <pmladek@suse.com>
Cc: jpoimboe@redhat.com, jeyu@kernel.org, jikos@kernel.org,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
jbaron@akamai.com
Subject: Re: [PATCH 2/2] livepatch: Allow loading modules on architectures without HAVE_RELIABLE_STACKTRACE
Date: Fri, 22 Dec 2017 14:12:59 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.1712221411070.25210@pobox.suse.cz> (raw)
In-Reply-To: <20171221151428.rt4dlizxb5nqhb3h@pathway.suse.cz>
On Thu, 21 Dec 2017, Petr Mladek wrote:
> On Fri 2017-12-08 18:25:23, Miroslav Benes wrote:
> > Now that immediate feature was removed, it is not possible to load
> > livepatch modules on architectures without HAVE_RELIABLE_STACKTRACE. Fix
> > it by removing guilty check in klp_register_patch().
> >
> > The architectures without HAVE_RELIABLE_STACKTRACE will now rely only on
> > kernelspace/userspace boundary switching, the (fake) signal and force
> > feature.
>
> I do not thing that this is a good idea. It encourages people to use
> the force feature. They might get used to it.
>
> If people are going to provide livepatches, they should be capable
> enough to provide a kernel where it is allowed. IMHO, the upstream
> kernel should not support bad/dirty practices out of box.
You're probably right.
It is true that with immediate gone the only reasonable thing for all
supported architectures is to provide HAVE_RELIABLE_STACKTRACE.
Miroslav
prev parent reply other threads:[~2017-12-22 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 17:25 [PATCH 0/2] Remove immediate feature Miroslav Benes
2017-12-08 17:25 ` [PATCH 1/2] livepatch: " Miroslav Benes
2017-12-20 14:35 ` Petr Mladek
2017-12-20 17:09 ` Josh Poimboeuf
2017-12-21 13:30 ` Petr Mladek
2017-12-21 13:55 ` Miroslav Benes
2017-12-21 14:58 ` Petr Mladek
2017-12-22 13:10 ` Miroslav Benes
2017-12-08 17:25 ` [PATCH 2/2] livepatch: Allow loading modules on architectures without HAVE_RELIABLE_STACKTRACE Miroslav Benes
2017-12-21 15:14 ` Petr Mladek
2017-12-22 13:12 ` Miroslav Benes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1712221411070.25210@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=jbaron@akamai.com \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).