From: Miroslav Benes <mbenes@suse.cz> To: Petr Mladek <pmladek@suse.com> Cc: Jiri Kosina <jikos@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Jason Baron <jbaron@akamai.com>, Joe Lawrence <joe.lawrence@redhat.com>, Evgenii Shatokhin <eshatokhin@virtuozzo.com>, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu <jeyu@kernel.org> Subject: Re: [PATCH v13 08/12] livepatch: Add atomic replace Date: Fri, 23 Nov 2018 13:00:35 +0100 (CET) [thread overview] Message-ID: <alpine.LSU.2.21.1811222132050.19197@pobox.suse.cz> (raw) In-Reply-To: <20181015123713.25868-9-pmladek@suse.com> On Mon, 15 Oct 2018, Petr Mladek wrote: > +static int klp_add_object_nops(struct klp_patch *patch, > + struct klp_object *old_obj) > +{ > + struct klp_object *obj; > + struct klp_func *func, *old_func; > + > + obj = klp_find_object(patch, old_obj); > + > + if (!obj) { > + obj = klp_alloc_object_dynamic(old_obj->name); > + if (!obj) > + return -ENOMEM; > + > + list_add(&obj->node, &patch->obj_list); > + } > + > + klp_for_each_func(old_obj, old_func) { > + func = klp_find_func(obj, old_func); > + if (func) > + continue; > + > + func = klp_alloc_func_nop(old_func, obj); > + if (!func) > + return -ENOMEM; > + > + list_add(&func->node, &obj->func_list); > + } > + > + return 0; > +} Maybe you should consider list_add_tail() here too. > + > +/* > + * Add 'nop' functions which simply return to the caller to run > + * the original function. The 'nop' functions are added to a > + * patch to facilitate a 'replace' mode. > + */ > +static int klp_add_nops(struct klp_patch *patch) > +{ > + struct klp_patch *old_patch; > + struct klp_object *old_obj; > + int err = 0; The initialization is unnecessary. > + list_for_each_entry(old_patch, &klp_patches, list) { > + klp_for_each_object(old_patch, old_obj) { > + err = klp_add_object_nops(patch, old_obj); > + if (err) > + return err; > + } > + } > + > + return 0; > +} Miroslav
next prev parent reply other threads:[~2018-11-23 12:00 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-15 12:37 [PATCH v13 00/12] livepatch: Atomic replace feature Petr Mladek 2018-10-15 12:37 ` [PATCH v13 01/12] livepatch: Change void *new_func -> unsigned long new_addr in struct klp_func Petr Mladek 2018-10-15 12:37 ` [PATCH v13 02/12] livepatch: Helper macros to define livepatch structures Petr Mladek 2018-10-17 18:17 ` Josh Poimboeuf 2018-10-18 11:11 ` Petr Mladek 2018-10-18 12:58 ` Josh Poimboeuf 2018-10-24 11:28 ` Petr Mladek 2018-11-21 12:17 ` Miroslav Benes 2018-10-15 12:37 ` [PATCH v13 03/12] livepatch: Shuffle klp_enable_patch()/klp_disable_patch() code Petr Mladek 2018-10-15 12:37 ` [PATCH v13 04/12] livepatch: Consolidate klp_free functions Petr Mladek 2018-10-17 18:22 ` Josh Poimboeuf 2018-10-18 11:40 ` Petr Mladek 2018-11-21 13:59 ` Miroslav Benes 2018-11-21 14:40 ` Petr Mladek 2018-10-15 12:37 ` [PATCH v13 05/12] livepatch: Refuse to unload only livepatches available during a forced transition Petr Mladek 2018-10-17 18:35 ` Josh Poimboeuf 2018-10-18 12:09 ` Petr Mladek 2018-10-18 13:00 ` Josh Poimboeuf 2018-10-15 12:37 ` [PATCH v13 06/12] livepatch: Simplify API by removing registration step Petr Mladek 2018-10-17 19:06 ` Josh Poimboeuf 2018-10-18 12:33 ` Petr Mladek 2018-10-15 12:37 ` [PATCH v13 07/12] livepatch: Use lists to manage patches, objects and functions Petr Mladek 2018-10-17 20:31 ` Josh Poimboeuf 2018-10-18 12:34 ` Petr Mladek 2018-10-15 12:37 ` [PATCH v13 08/12] livepatch: Add atomic replace Petr Mladek 2018-11-23 12:00 ` Miroslav Benes [this message] 2018-10-15 12:37 ` [PATCH v13 09/12] livepatch: Remove Nop structures when unused Petr Mladek 2018-10-17 20:48 ` Josh Poimboeuf 2018-10-18 12:40 ` Petr Mladek 2018-10-15 12:37 ` [PATCH v13 10/12] livepatch: Atomic replace and cumulative patches documentation Petr Mladek 2018-10-15 12:37 ` [PATCH v13 11/12] livepatch: Remove ordering and refuse loading conflicting patches Petr Mladek 2018-10-15 12:37 ` [PATCH v13 12/12] selftests/livepatch: introduce tests Petr Mladek 2018-10-15 19:46 ` Joe Lawrence 2018-10-17 20:48 ` Josh Poimboeuf 2018-10-18 13:34 ` [PATCH v13 00/12] livepatch: Atomic replace feature Josh Poimboeuf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.LSU.2.21.1811222132050.19197@pobox.suse.cz \ --to=mbenes@suse.cz \ --cc=eshatokhin@virtuozzo.com \ --cc=jbaron@akamai.com \ --cc=jeyu@kernel.org \ --cc=jikos@kernel.org \ --cc=joe.lawrence@redhat.com \ --cc=jpoimboe@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=live-patching@vger.kernel.org \ --cc=pmladek@suse.com \ --subject='Re: [PATCH v13 08/12] livepatch: Add atomic replace' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).