From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6748C04EB9 for ; Mon, 3 Dec 2018 15:00:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 935AD20850 for ; Mon, 3 Dec 2018 15:00:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 935AD20850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726885AbeLCPAC (ORCPT ); Mon, 3 Dec 2018 10:00:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:36116 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726116AbeLCPAC (ORCPT ); Mon, 3 Dec 2018 10:00:02 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C44DEAD47; Mon, 3 Dec 2018 14:59:58 +0000 (UTC) Date: Mon, 3 Dec 2018 15:59:57 +0100 (CET) From: Miroslav Benes To: Petr Mladek cc: Jiri Kosina , Josh Poimboeuf , Jason Baron , Joe Lawrence , Evgenii Shatokhin , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu Subject: Re: [PATCH v14 03/11] livepatch: Consolidate klp_free functions In-Reply-To: <20181129094431.7801-4-pmladek@suse.com> Message-ID: References: <20181129094431.7801-1-pmladek@suse.com> <20181129094431.7801-4-pmladek@suse.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Nov 2018, Petr Mladek wrote: > -static int klp_init_patch(struct klp_patch *patch) > +/* Init operations that must succeed before klp_free_patch() can be called. */ > +static int klp_init_patch_before_free(struct klp_patch *patch) There is no klp_free_patch() now, so the comment is not correct. Also I don't know if the function name is ideal, but I don't have a better one. > { > struct klp_object *obj; > - int ret; > + struct klp_func *func; > > if (!patch->objs) > return -EINVAL; > > - mutex_lock(&klp_mutex); > - > + INIT_LIST_HEAD(&patch->list); > + patch->kobj_alive = false; > patch->enabled = false; > init_completion(&patch->finish); > > - ret = kobject_init_and_add(&patch->kobj, &klp_ktype_patch, > - klp_root_kobj, "%s", patch->mod->name); > + klp_for_each_object(patch, obj) { > + if (!obj->funcs) > + return -EINVAL; > + > + obj->kobj_alive = false; > + > + klp_for_each_func(obj, func) > + func->kobj_alive = false; > + } > + > + return 0; > +} > + > +static int klp_init_patch(struct klp_patch *patch) > +{ > + struct klp_object *obj; > + int ret; > + > + mutex_lock(&klp_mutex); > + > + ret = klp_init_patch_before_free(patch); > if (ret) { > mutex_unlock(&klp_mutex); > return ret; > } > > + ret = kobject_init_and_add(&patch->kobj, &klp_ktype_patch, > + klp_root_kobj, "%s", patch->mod->name); > + if (ret) > + goto free; Is this intentional? It should be sufficient (and it was before the patch) to unlock the mutex and return ret. We do not need to free anything here. Only klp_patch instance was initialized and that is all. Otherwise it looks good. kobj_alive feels safer than state_initialized. Thanks, Miroslav