From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F76C2D0F3 for ; Wed, 1 Apr 2020 13:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D3FD206F6 for ; Wed, 1 Apr 2020 13:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732802AbgDANyF (ORCPT ); Wed, 1 Apr 2020 09:54:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:48728 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732234AbgDANyE (ORCPT ); Wed, 1 Apr 2020 09:54:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B6F8AABC6; Wed, 1 Apr 2020 13:54:03 +0000 (UTC) Date: Wed, 1 Apr 2020 15:54:03 +0200 (CEST) From: Miroslav Benes To: Julien Thierry cc: linux-kernel@vger.kernel.org, jpoimboe@redhat.com, peterz@infradead.org, raphael.gault@arm.com Subject: Re: [PATCH v2 07/10] objtool: check: Allow save/restore hint in non standard function symbols In-Reply-To: <20200327152847.15294-8-jthierry@redhat.com> Message-ID: References: <20200327152847.15294-1-jthierry@redhat.com> <20200327152847.15294-8-jthierry@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2020, Julien Thierry wrote: > The kernel code base provides CODE_SYM_START/END to declare assembly > code sequences that don't follow function standard calling conventions. > > As non-C/non-standard code, these sequences can very much benefit from > unwind hints. However, when a restore unwind_hint is used in a > non-function code sequence, objtool will crash when looking for the > corresponding save hint. > > Record the code symbol an instruction belongs to and look for save hints > belonging to the same code symbol as the restore hint. > > Signed-off-by: Julien Thierry Looks ok, but save/restore hints are about to go away. See https://lore.kernel.org/lkml/20200331222703.GH2452@worktop.programming.kicks-ass.net/ Miroslav