From: Miroslav Benes <mbenes@suse.cz>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jirislaby@kernel.org>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] stacktrace: Remove reliable argument from arch_stack_walk() callback
Date: Fri, 17 Jul 2020 11:04:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2007171103070.21694@pobox.suse.cz> (raw)
In-Reply-To: <20200715202821.12220-2-broonie@kernel.org>
On Wed, 15 Jul 2020, Mark Brown wrote:
> Currently the callback passed to arch_stack_walk() has an argument called
> reliable passed to it to indicate if the stack entry is reliable, a comment
> says that this is used by some printk() consumers. However in the current
> kernel none of the arch_stack_walk() implementations ever set this flag to
> true and the only callback implementation we have is in the generic
> stacktrace code which ignores the flag. It therefore appears that this
> flag is redundant so we can simplify and clarify things by removing it.
Correct. I dug around and it seems it was the case even when it was
introduced. So I wonder about the comment. I don't remember the details,
maybe Thomas or someone else does. But the patch looks correct.
Miroslav
next prev parent reply other threads:[~2020-07-17 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 20:28 [PATCH 0/3] arm64: Convert to ARCH_STACKWALK Mark Brown
2020-07-15 20:28 ` [PATCH 1/3] stacktrace: Remove reliable argument from arch_stack_walk() callback Mark Brown
2020-07-17 9:04 ` Miroslav Benes [this message]
2020-07-15 20:28 ` [PATCH 2/3] arm64: stacktrace: Make stack walk callback consistent with generic code Mark Brown
2020-07-15 20:28 ` [PATCH 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK Mark Brown
2020-07-16 11:56 ` Miroslav Benes
2020-07-16 16:20 ` Mark Brown
2020-07-17 9:06 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2007171103070.21694@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).