From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42A8C4361B for ; Wed, 16 Dec 2020 12:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61FB92339F for ; Wed, 16 Dec 2020 12:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726044AbgLPMtA (ORCPT ); Wed, 16 Dec 2020 07:49:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:59574 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbgLPMtA (ORCPT ); Wed, 16 Dec 2020 07:49:00 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DF734AC91; Wed, 16 Dec 2020 12:48:18 +0000 (UTC) Date: Wed, 16 Dec 2020 13:48:18 +0100 (CET) From: Miroslav Benes To: Josh Poimboeuf cc: x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , clang-built-linux@googlegroups.com, Arnd Bergmann , Nick Desaulniers Subject: Re: [PATCH] objtool: Fix seg fault with Clang non-section symbols In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Dec 2020, Josh Poimboeuf wrote: > The Clang assembler likes to strip section symbols, which means objtool > can't reference some text code by its section. This confuses objtool > greatly, causing it to seg fault. > > The fix is similar to what was done before, for ORC reloc generation: > > e81e07244325 ("objtool: Support Clang non-section symbols in ORC generation") > > Factor out that code into a common helper and use it for static call > reloc generation as well. > > Reported-by: Arnd Bergmann > Reviewed-by: Nick Desaulniers > Link: https://github.com/ClangBuiltLinux/linux/issues/1207 > Signed-off-by: Josh Poimboeuf Reviewed-by: Miroslav Benes M