From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C001C33CB7 for ; Wed, 29 Jan 2020 21:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CA3C2071E for ; Wed, 29 Jan 2020 21:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727468AbgA2VKG (ORCPT ); Wed, 29 Jan 2020 16:10:06 -0500 Received: from mga03.intel.com ([134.134.136.65]:46432 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727208AbgA2VKG (ORCPT ); Wed, 29 Jan 2020 16:10:06 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 13:10:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,379,1574150400"; d="scan'208";a="429805093" Received: from cmossx-mobl1.amr.corp.intel.com ([10.251.7.89]) by fmsmga006.fm.intel.com with ESMTP; 29 Jan 2020 13:10:04 -0800 Date: Wed, 29 Jan 2020 13:10:04 -0800 (PST) From: Mat Martineau X-X-Sender: mjmartin@cmossx-mobl1.amr.corp.intel.com To: Geert Uytterhoeven cc: Paolo Abeni , Florian Westphal , Christoph Paasch , Matthieu Baerts , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mptcp: Fix incorrect IPV6 dependency check In-Reply-To: <20200129180117.545-1-geert@linux-m68k.org> Message-ID: References: <20200129180117.545-1-geert@linux-m68k.org> User-Agent: Alpine 2.21 (OSX 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jan 2020, Geert Uytterhoeven wrote: > If CONFIG_MPTCP=y, CONFIG_MPTCP_IPV6=n, and CONFIG_IPV6=m: > > net/mptcp/protocol.o: In function `__mptcp_tcp_fallback': > protocol.c:(.text+0x786): undefined reference to `inet6_stream_ops' > > Fix this by checking for CONFIG_MPTCP_IPV6 instead of CONFIG_IPV6, like > is done in all other places in the mptcp code. > > Fixes: 8ab183deb26a3b79 ("mptcp: cope with later TCP fallback") > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Mat Martineau -- Mat Martineau Intel