linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: <linux-kernel@vger.kernel.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Jonathan Corbet <corbet@lwn.net>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-iio@vger.kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v5 4/9] dt-bindings: iio: iio-mux: document iio-mux bindings
Date: Tue, 29 Nov 2016 16:56:37 +0100	[thread overview]
Message-ID: <b00ae997-4466-29b8-b484-3a0970e65386@axentia.se> (raw)
In-Reply-To: <1480414245-14034-5-git-send-email-peda@axentia.se>

On 2016-11-29 11:10, Peter Rosin wrote:
> +Example:
> +	mux: mux-controller {
> +		compatible = "mux-gpio";
> +		#mux-control-cells = <0>;
> +
> +		mux-gpios = <&pioA 0 GPIO_ACTIVE_HIGH>,
> +			    <&pioA 1 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	adc-mux {
> +		compatible = "iio-mux";
> +		io-channels = <&adc 0>;
> +		io-channel-names = "parent";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		mux-controls = <&mux>;
> +
> +		sync@0 {
> +			reg = <0>;
> +		};
> +
> +		in@1 {
> +			reg = <1>;
> +		};
> +
> +		system-regulator@2 {
> +			reg = <2>;
> +		};
> +	};

Hmmm, a more compact binding would be to just use an array of strings
instead of a list of children for the mux channels, and use the array
index as channel number, like so:

	adc-mux {
		compatible = "iio-mux";
		io-channels = <&adc 0>;
		io-channel-names = "parent";

		mux-controls = <&mux>;

		channels = "sync", "in", "system-regulator";
	};

If you need to skip a low-number channel, you'd just put an empty string
for that channel. If you need to skip channels at the end, just stop
short.

Can anyone think of any reason to add anything to the channel nodes
that makes the string-array ineffective? If so, or if that comes up
later, it could be optional and in that case you could look for the
channels property first and then, if not present, iterate over child
nodes.

Opinions? I like it, it's a lot more compact...

Cheers,
Peter

  reply	other threads:[~2016-11-29 15:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 10:10 [PATCH v5 0/9] mux controller abstraction and iio/i2c muxes Peter Rosin
2016-11-29 10:10 ` [PATCH v5 1/9] dt-bindings: document devicetree bindings for mux-controllers and mux-gpio Peter Rosin
2016-11-29 10:10 ` [PATCH v5 2/9] misc: minimal mux subsystem and gpio-based mux controller Peter Rosin
2016-11-29 10:10 ` [PATCH v5 3/9] iio: inkern: api for manipulating ext_info of iio channels Peter Rosin
2016-11-29 10:10 ` [PATCH v5 4/9] dt-bindings: iio: iio-mux: document iio-mux bindings Peter Rosin
2016-11-29 15:56   ` Peter Rosin [this message]
2016-11-29 10:10 ` [PATCH v5 5/9] iio: multiplexer: new iio category and iio-mux driver Peter Rosin
2016-11-29 10:10 ` [PATCH v5 6/9] dt-bindings: i2c: i2c-mux-simple: document i2c-mux-simple bindings Peter Rosin
2016-11-29 10:10 ` [PATCH v5 7/9] i2c: i2c-mux-simple: new driver Peter Rosin
2016-11-29 10:10 ` [PATCH v5 8/9] dt-bindings: mux-adg792a: document devicetree bindings for ADG792A/G mux Peter Rosin
2016-11-29 10:10 ` [PATCH v5 9/9] misc: mux-adg792a: add mux controller driver for ADG792A/G Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b00ae997-4466-29b8-b484-3a0970e65386@axentia.se \
    --to=peda@axentia.se \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).