From: Bart Van Assche <bvanassche@acm.org>
To: Tejun Heo <tj@kernel.org>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@vger.kernel.org, cgroups@vger.kernel.org,
newella@fb.com, josef@toxicpanda.com
Subject: Re: [PATCH 2/5] block: add request->io_data_len
Date: Wed, 8 Apr 2020 20:44:17 -0700 [thread overview]
Message-ID: <b027a718-1c76-6e34-1edb-5435a5605d35@acm.org> (raw)
In-Reply-To: <20200408201450.3959560-3-tj@kernel.org>
On 2020-04-08 13:14, Tejun Heo wrote:
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 32868fbedc9e..bfd34c6a27ef 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -142,6 +142,14 @@ struct request {
>
> /* the following two fields are internal, NEVER access directly */
> unsigned int __data_len; /* total data len */
> +#ifdef CONFIG_BLK_RQ_IO_DATA_LEN
> + /*
> + * Total data len at the time of issue. This doesn't get deducted by
> + * blk_update_request() and can be used by completion path to determine
> + * the request size.
> + */
> + unsigned int io_data_len;
> +#endif
> sector_t __sector; /* sector cursor */
>
> struct bio *bio;
So we have one struct member with the description "total data len" and
another struct member with the description "total data len at the time
of issue"? How could one not get confused by these descriptions?
This change makes the comment above __data_len incorrect. Please update
that comment or move io_data_len in front of that comment.
How does this change interact with the code in drivers/scsi/sd.c that
manipulates __data_len directly?
Thanks,
Bart.
next prev parent reply other threads:[~2020-04-09 3:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 20:14 [PATCHSET block/for-5.8] iocost: improve use_delay and latency target handling Tejun Heo
2020-04-08 20:14 ` [PATCH 1/5] blk-iocost: switch to fixed non-auto-decaying use_delay Tejun Heo
2020-04-08 20:14 ` [PATCH 2/5] block: add request->io_data_len Tejun Heo
2020-04-09 1:44 ` Ming Lei
2020-04-09 2:11 ` Tejun Heo
2020-04-09 2:38 ` Ming Lei
2020-04-09 5:08 ` Pavel Begunkov
2020-04-13 14:02 ` Tejun Heo
2020-04-13 13:56 ` Tejun Heo
2020-04-09 3:44 ` Bart Van Assche [this message]
2020-04-13 13:52 ` Tejun Heo
2020-04-08 20:14 ` [PATCH 3/5] blk-iocost: account for IO size when testing latencies Tejun Heo
2020-04-08 20:14 ` [PATCH 4/5] iocost_monitor: exit successfully if interval is zero Tejun Heo
2020-04-08 20:14 ` [PATCH 5/5] iocost_monitor: drop string wrap around numbers when outputting json Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b027a718-1c76-6e34-1edb-5435a5605d35@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=newella@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).