From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org
Cc: Qais Yousef <qais.yousef@arm.com>,
Lingutla Chandrasekhar <clingutla@codeaurora.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Quentin Perret <qperret@google.com>,
Pavan Kondeti <pkondeti@codeaurora.org>,
Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper
Date: Tue, 6 Apr 2021 17:37:18 +0200 [thread overview]
Message-ID: <b03ae299-0b0c-3090-4d16-edbf2bdd5edb@arm.com> (raw)
In-Reply-To: <20210401193006.3392788-4-valentin.schneider@arm.com>
On 01/04/2021 21:30, Valentin Schneider wrote:
> During load-balance, groups classified as group_misfit_task are filtered
> out if they do not pass
>
> group_smaller_max_cpu_capacity(<candidate group>, <local group>);
>
> which itself employs fits_capacity() to compare the sgc->max_capacity of
> both groups.
>
> Due to the underlying margin, fits_capacity(X, 1024) will return false for
> any X > 819. Tough luck, the capacity_orig's on e.g. the Pixel 4 are
> {261, 871, 1024}. If a CPU-bound task ends up on one of those "medium"
> CPUs, misfit migration will never intentionally upmigrate it to a CPU of
> higher capacity due to the aforementioned margin.
>
> One may argue the 20% margin of fits_capacity() is excessive in the advent
> of counter-enhanced load tracking (APERF/MPERF, AMUs), but one point here
> is that fits_capacity() is meant to compare a utilization value to a
> capacity value, whereas here it is being used to compare two capacity
> values. As CPU capacity and task utilization have different dynamics, a
> sensible approach here would be to add a new helper dedicated to comparing
> CPU capacities.
>
> While at it, replace group_smaller_{min, max}_cpu_capacity() with
> comparisons of the source group's min/max capacity and the destination
> CPU's capacity.
IMHO, you haven't mentioned why you replace local sched group with dst
CPU. I can see that only the capacity of the dst CPU makes really sense
here. Might be worth mentioning in the patch header why. There is some
of it in v3 6/7 but that's a different change.
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
[...]
next prev parent reply other threads:[~2021-04-06 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 19:30 [PATCH v4 0/3] sched/fair: load-balance vs capacity margins Valentin Schneider
2021-04-01 19:30 ` [PATCH v4 1/3] sched/fair: Ignore percpu threads for imbalance pulls Valentin Schneider
2021-04-02 12:52 ` Vincent Guittot
2021-04-06 15:35 ` Dietmar Eggemann
2021-04-06 15:55 ` Valentin Schneider
2021-04-01 19:30 ` [PATCH v4 2/3] sched/fair: Clean up active balance nr_balance_failed trickery Valentin Schneider
2021-04-02 12:57 ` Vincent Guittot
2021-04-06 15:36 ` Dietmar Eggemann
2021-04-01 19:30 ` [PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper Valentin Schneider
2021-04-02 13:04 ` Vincent Guittot
2021-04-06 15:37 ` Dietmar Eggemann [this message]
2021-04-06 15:59 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b03ae299-0b0c-3090-4d16-edbf2bdd5edb@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=clingutla@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=riel@surriel.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).