linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 01/13] tools/libperf: introduce notion of static polled file descriptors
Date: Wed, 3 Jun 2020 15:01:43 +0300	[thread overview]
Message-ID: <b04311d6-b1c6-d625-b227-9ae4f4370626@linux.intel.com> (raw)
In-Reply-To: <33c91520-7040-bd6b-b176-004ddbec2a63@intel.com>

Hi,

On 03.06.2020 14:38, Adrian Hunter wrote:
> On 1/06/20 11:05 pm, Alexey Budankov wrote:
>>
>> Implement adding of file descriptors by fdarray__add_stat() to
>> fix-sized (currently 1) stat_entries array located at struct fdarray.
>> Append added file descriptors to the array used by poll() syscall
>> during fdarray__poll() call. Copy poll() result of the added
>> descriptors from the array back to the storage for separate analysis.
> 
> Why not instead call evlist__add_pollfd() before other fds are added, so
> the fda->entries[] position is always fixed. Then this patch is not needed.

It then will block event consumption loop, at least in record mode, due to
change sin initial assumptions behind fdarray__filter(). So extension of the
API with 'static' fds looks safer w.r.t. possible functional regressions at 
the same time extending the API with ability to atomically wait for (poll())
not only event fds but also any other fds during monitoring.

Feel free to ask more.

~Alexey

  reply	other threads:[~2020-06-03 12:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 20:01 [PATCH v6 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-06-01 20:05 ` [PATCH v6 01/13] tools/libperf: introduce notion of static polled file descriptors Alexey Budankov
2020-06-03 11:38   ` Adrian Hunter
2020-06-03 12:01     ` Alexey Budankov [this message]
2020-06-03 12:23       ` Adrian Hunter
2020-06-03 12:30         ` Hunter, Adrian
2020-06-03 12:52           ` Alexey Budankov
2020-06-03 15:53             ` Adrian Hunter
2020-06-03 17:00               ` Alexey Budankov
2020-06-01 20:06 ` [PATCH v6 02/13] perf evlist: introduce control " Alexey Budankov
2020-06-01 20:07 ` [PATCH v6 03/13] perf evlist: implement control command handling functions Alexey Budankov
2020-06-01 20:08 ` [PATCH v6 04/13] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-06-01 20:08 ` [PATCH v6 05/13] perf stat: move target check to loop control statement Alexey Budankov
2020-06-01 20:09 ` [PATCH v6 06/13] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-06-01 20:10 ` [PATCH v6 07/13] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-06-01 20:15 ` [PATCH v6 08/13] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-06-01 20:17 ` [PATCH v6 09/13] perf stat: implement control commands handling Alexey Budankov
2020-06-01 20:17 ` [PATCH v6 10/13] perf stat: introduce --ctl-fd[-ack] options Alexey Budankov
2020-06-01 20:18 ` [PATCH v6 11/13] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-06-01 20:19 ` [PATCH v6 12/13] perf record: implement control commands handling Alexey Budankov
2020-06-01 20:20 ` [PATCH v6 13/13] perf record: introduce --ctl-fd[-ack] options Alexey Budankov
2020-06-03 12:24   ` Adrian Hunter
2020-06-03 12:52     ` Alexey Budankov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b04311d6-b1c6-d625-b227-9ae4f4370626@linux.intel.com \
    --to=alexey.budankov@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).