From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756223AbcIVL2s (ORCPT ); Thu, 22 Sep 2016 07:28:48 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:33829 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbcIVL2l (ORCPT ); Thu, 22 Sep 2016 07:28:41 -0400 Subject: Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0 To: sean.wang@mediatek.com, john@phrozen.org, davem@davemloft.net References: <1474511636-11644-1-git-send-email-sean.wang@mediatek.com> <1474511636-11644-4-git-send-email-sean.wang@mediatek.com> Cc: nbd@openwrt.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, andrew@lunn.ch, f.fainelli@gmail.com, keyhaede@gmail.com, objelf@gmail.com From: Sergei Shtylyov Message-ID: Date: Thu, 22 Sep 2016 14:28:36 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474511636-11644-4-git-send-email-sean.wang@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/22/2016 5:33 AM, sean.wang@mediatek.com wrote: > From: Sean Wang > > Add the dts property for the capability if TRGMII supported on GAMC0 > > Signed-off-by: Sean Wang > --- > Documentation/devicetree/bindings/net/mediatek-net.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt > index 6103e55..7111278 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt > @@ -31,7 +31,10 @@ Optional properties: > Required properties: > - compatible: Should be "mediatek,eth-mac" > - reg: The number of the MAC > -- phy-handle: see ethernet.txt file in the same directory. > +- phy-handle: see ethernet.txt file in the same directory and > + the phy-mode "trgmii" required being provided when reg Since you've modified the generic parser of the "phy-mode" to add your "trgmii", you also need to update ethernet.txt... > + is equal to 0 and the MAC uses fixed-link to connect > + with inernal switch such as MT7530. Internal. [...] MBR, Sergei