From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14472C5517A for ; Mon, 26 Oct 2020 17:00:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC2AB22450 for ; Mon, 26 Oct 2020 17:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603731643; bh=Wk5C6AUNf5Rr1fEwHl+3seiMfHFBEAh2bYObiBXLLX8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=cIxTWLXBlLzRQQE9bpGR0xxDPxlzh4ouqDFCAD9aQz1pTEutK+leaoysmWiPSAvG8 3gwctofE180hDA66Qp5UNUa2NUuvbzfZVvzy198bWzag7bmFoCfFZBSnoWOTOggnOK bNrmiP//4DwYz692Px3K8tupt8M37o9+mv6L7IHY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1775564AbgJZRAm (ORCPT ); Mon, 26 Oct 2020 13:00:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:49416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2443346AbgJZRA1 (ORCPT ); Mon, 26 Oct 2020 13:00:27 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7ADDF223B0; Mon, 26 Oct 2020 17:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603731626; bh=Wk5C6AUNf5Rr1fEwHl+3seiMfHFBEAh2bYObiBXLLX8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gdSIPYRyIpe/ZiMe9+II8R3w/Q5DiXCBun6pAQDRIAwQw8M+JPaVNaxoVmwuXDu6F ZGxBvlO2AiSwjUnczyLL8j/XuVhZWATASl4r1ZZQKUsQDStM9ly9RnTTPNe6B/8CuU LtmytiLl0WgVhtcG6POJPHmyUoecnSNtC2CKceyY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kX5r6-004OVS-Jc; Mon, 26 Oct 2020 17:00:24 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Oct 2020 17:00:24 +0000 From: Marc Zyngier To: Kevin Hilman Cc: Neil Armstrong , jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module In-Reply-To: <7ha6w9hsfm.fsf@baylibre.com> References: <20201020072532.949137-1-narmstrong@baylibre.com> <87v9eyo75s.wl-maz@kernel.org> <7ha6w9hsfm.fsf@baylibre.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: khilman@baylibre.com, narmstrong@baylibre.com, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-10-26 16:18, Kevin Hilman wrote: > Marc Zyngier writes: > >> On Tue, 20 Oct 2020 08:25:30 +0100, >> Neil Armstrong wrote: >>> >>> In order to reduce the kernel Image size on multi-platform >>> distributions, >>> make it possible to build the Amlogic GPIO IRQ controller as a module >>> by switching it to a platform driver. >>> >>> The second patch removes MESON_IRQ_GPIO selection from ARCH_MESON to >>> allow >>> building the driver as module. >>> >>> Neil Armstrong (2): >>> irqchip: irq-meson-gpio: make it possible to build as a module >>> arm64: meson: remove MESON_IRQ_GPIO selection >>> >>> arch/arm64/Kconfig.platforms | 1 - >>> drivers/irqchip/Kconfig | 5 +- >>> drivers/irqchip/irq-meson-gpio.c | 89 >>> ++++++++++++++++++++------------ >>> 3 files changed, 59 insertions(+), 36 deletions(-) >> >> I've tried this series on my vim3l with the this driver compiled as a >> module, and lost the Ethernet interface in the process, as the phy >> wasn't able to resolve its interrupt and things fail later on: >> >> [ 72.238291] meson8b-dwmac ff3f0000.ethernet eth1: no phy at addr -1 >> [ 72.238917] meson8b-dwmac ff3f0000.ethernet eth1: stmmac_open: >> Cannot attach to PHY (error: -19) >> >> This is a generic problem with making DT-based interrupt controllers >> modular when not *all* the drivers can deal with probing deferral. > > Yes, but this series still keeps the default as built-in. > > If you build as a module, and you add `fw_devlink=on` to the kernel > command-line, device-links will be created based on DT dependencies > which will ensure the right module load order. It doesn't work here. I get the exact same error (well, with eth0 instead of eth1). In my experience, fw_devlink isn't reliable yet. Config on request. > I've tested this series with `fw_devlink=on` on several Amlogic > platforms and it works just fine, but since it requires the extra > cmdline option, I think the default should remain built-in. > > So, I'd still like to see this series merged so that at least it's an > option to enable this as a module. I have taken similar patches in 5.9 for other SoC families (qcomm, mtk), and ended up reverting them in -rc2, because there is simply too much breakage. Even keeping it as built in changes the init order, which tons of drivers depend on. I proposed a middle-of-the-road approach (modules can break, built-in stays the same) which Rob pushed back on. So either we fix fw_devlink to work for everything and be on by default, or we keep the current setup. > Also, another reason to make it optional is that not all platforms need > this feature at all, but right now we select it for all Amlogic SoCs. I understand that, but I don't want another episode of widespread breakages, and this series definitely breaks things. Thanks, M. -- Jazz is not dead. It just smells funny...