Re: [PATCH 2.6.17-rc6 7/9] Remove some of the kmemleak false positives

From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.17-rc6 7/9] Remove some of the kmemleak false positives
Date: Mon, 12 Jun 2006 09:11:07 +0100	[thread overview]
Message-ID: <b0943d9e0606120111v310f8556k30b6939d520d56d8@mail.gmail.com> (raw)
In-Reply-To: <84144f020606112219m445a3ccas7a95c7339ca5fa10@mail.gmail.com>

On 12/06/06, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> Hi Catalin,
>
> On 6/11/06, Catalin Marinas <catalin.marinas@gmail.com> wrote:
> > There are allocations for which the main pointer cannot be found but they
> > are not memory leaks. This patch fixes some of them.
>
> Can we fix this by looking for pointers to anywhere in the allocated
> memory block instead of just looking for the start?

I thought about this as well (I think that's how Valgrind works) but
it would increase the chances of missing real leaks. It currently
looks for the start of the block and a few locations inside the block
(those from which the main pointer is computed using the
container_of() macro).

I need to do some tests to see how it works but I won't be able to use
the radix_tree (as storing each location in the block would lead to a
huge tree).

-- 
Catalin