From: Michael Straube <straube.linux@gmail.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove null check before vfree
Date: Sat, 28 Aug 2021 21:30:14 +0200 [thread overview]
Message-ID: <b098cbe9-1cc6-d97f-e1d8-df6c99b0afa0@gmail.com> (raw)
In-Reply-To: <1e31610a-0324-dfb7-abe5-f05d652d461d@gmail.com>
On 8/28/21 21:20, Michael Straube wrote:
> On 8/28/21 19:54, Saurav Girepunje wrote:
>> Remove NULL check. NULL check before freeing function is not needed.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>> drivers/staging/r8188eu/core/rtw_sta_mgt.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>> b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>> index f6dffed53a60..4726771a8403 100644
>> --- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>> +++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>> @@ -155,9 +155,7 @@ u32 _rtw_free_sta_priv(struct sta_priv
>> *pstapriv)
>> spin_unlock_bh(&pstapriv->sta_hash_lock);
>> /*===============================*/
>>
>> - if (pstapriv->pallocated_stainfo_buf)
>> - vfree(pstapriv->pallocated_stainfo_buf);
>> - }
>> + vfree(pstapriv->pallocated_stainfo_buf);
>>
>> return _SUCCESS;
>> }
>> --
>> 2.32.0
>>
>
> Acked-by: Michael Straube <straube.linux@gmail.com>
>
> Thanks,
> Michael
Whoops, I missed that you removed the } that belongs to the enclosing if
block. Probably because it is not properly indented in the original
code.
Best regards,
Michael
next prev parent reply other threads:[~2021-08-28 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 17:54 [PATCH] staging: r8188eu: core: remove null check before vfree Saurav Girepunje
2021-08-28 19:20 ` Michael Straube
2021-08-28 19:30 ` Michael Straube [this message]
2021-08-28 19:47 ` Kari Argillander
2021-08-28 19:56 ` Michael Straube
2021-08-28 19:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b098cbe9-1cc6-d97f-e1d8-df6c99b0afa0@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=ross.schm.dev@gmail.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).