From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA51C69300 for ; Thu, 8 Feb 2024 07:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707376514; cv=none; b=tcCV5i4GjCoTXWe3W5+HNay3N8WsEkeiSdCQkVe+sTL4GtvyZ0Qlozf10P3/+deYEOBKGKgPcQH6Gw9+rY0vjlMK9sDGTJrbRsUaRIc87FA3SkBOwqUhCvG2cDVQ7GZr+cwCJlvZOsE7fo3Fj16lLosWgmBKY1VSAAgnOkEtDUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707376514; c=relaxed/simple; bh=vK/5Gz1QSwmxYzRM+M3atdSA7U9sTy/frFNKMtYClAM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=YFWiQ0pTOT04pDZhJeyxMj+ox8gSpjDq6z8PfcrVHfrbOVzAie+jWH1Vtp3A+SOCT+Rj8oA67PSOgRQauZfiEMdgRF4Og4xiG3kQgvlQgohSO6c7OVr3IAIMZwlp6Ip4yvDgI/En0szaC6AHBDR1CiH6/esy4YkZE/PgBxk2ZzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uUI+o3Ug; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uUI+o3Ug" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5601eb97b29so1118464a12.0 for ; Wed, 07 Feb 2024 23:15:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707376510; x=1707981310; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Y5RJhuVckeXbSoDSHqZK4xAbBIVthUC0MdjCe3vhbYQ=; b=uUI+o3Ug0tOP1pHa2sPeAxzYX/C+aV5cFlfflRePncS18I6sepgqbQ0yXwvorU3iuU tifQnD9d4+mxNFDerrg50EAF65iJKXo1xRG49C2elUoXxt1LXcQNy1PTlStNEyqK+NAK Tg+AqwKMNTQmrpth8EyDRFmQuhQUYntTcjjtVg/vQY3ofhG4tmZL8iwsbX54w5XS+Fqz CVMm2RWpWBTqqoNy5MyJOTtdAuFSJKvxMC5iqQvUU1LvtMZs7oySkj77RkhH/No8ra1l lcHoaRi1d0ZWeiheU0brxvZId1FIVz384xQQGQsGMPsf8lSAtfSGGKp4ovbKEmj5imjb UR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707376510; x=1707981310; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y5RJhuVckeXbSoDSHqZK4xAbBIVthUC0MdjCe3vhbYQ=; b=bsSItzjBZlvR1iWI2Ih7TswI7SOYnyz634uOAb1oeF0+SRODQFIbkGqIhnEqoL9Sq7 GftRUFOWqWUb1gsds2tnCBPr57FvADrttn9rhIwO2MRIdCMKQLJYi+TMzgAceNB8QOaT wUT3auDaQfHfkk1/xUqlCgj3HvnQG6cHlWHu1cmyLX8s1HBgTEzb/w55HM4oQWaeA6iQ VHQ/yiYZrJ+4iK/fn9OjFQ914biXamZzrZYtQYlpECZgM74nd86jiG6MGie8+wrO4rqT vuWe7LSAdC6e+5K83HSThguu4HBcIAFFiRCUH4g9ARe5ekImFlzDso1zNHeGEUoP3ne8 5UIg== X-Forwarded-Encrypted: i=1; AJvYcCWOlWdKxeWTMjMoansIZyDfPAdFTT3Fpp9muPjowQTPFG8UBYY4cf6QuF7273SKv7q6ww3wdp8A8Y6XaxF2SaSryhBlt6jHhVPLnLsK X-Gm-Message-State: AOJu0Yw1sUn1BtW0lmHDyzzb99XQZUNyABet9hKcQEY8tV4cDzoO6RDg V6HQtA6n2fslpB0geB7JKk97c5RMLKZwUd1PxWUsBrTnwmywoiLW0QswXAH2BuY= X-Google-Smtp-Source: AGHT+IE4WyGx5+NrWJrNDbHiwts0XIOSGoJrDUDfeCg4GYwug22ZiFtQVShwh8Q0Vv/ctnQ5MLpqmQ== X-Received: by 2002:a05:6402:27c9:b0:561:123d:ed8c with SMTP id c9-20020a05640227c900b00561123ded8cmr431557ede.2.1707376509857; Wed, 07 Feb 2024 23:15:09 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW/5RW8GSuoXDIAlEWg7ccUX02G0LTAdoI9PvgnWCVnJUhkL4NYhlR+A/nuYNj13NEpDSSDb0h3CZsyf8rDSG5W3cqDBYw5dpIu8gEavLXiLqdQIQczCtsFoFs//XPDItH5TdG1ZQtqK2JUo+oXwCPJOi7OlDG8HdW6CvtZq/dUaWhGrDRszxT1yy5LGJeXaoMwn/ILyW+aQCTKZUCJiF4o5J0i1noq+8zyLAbV6cN8+cOk9Z0GSJnklCB3uEb+mA+Te3oG3iJA6Ez1jMuc+t3O+rdgKxfEyZ4Q1MVfCkiiopbf6M3bItpV9PdABDoFXlrmqKwhVN20XW+kMWak7iwVxCKcz910CK4mAYSOTHbUFwi6xOrPYojHudMVFKbOE69ZBKdveTfeOYvNiJ9Wshy2/1HLuD0lXWaCjij2TcgthPF3FXgCbcqt63ajk4IQuCJXW2U9ngxJYFFUmpzfmKwrATNcpfXMlFUMeuY+TDBK5UjGCUeUoPsy8M9IpUs7UzA/eqZ8yfF2f2Y= Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id cs4-20020a0564020c4400b005609619be04sm529701edb.41.2024.02.07.23.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 23:15:09 -0800 (PST) Date: Thu, 8 Feb 2024 10:15:06 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Ethan Zhao , baolu.lu@linux.intel.com, bhelgaas@google.com, robin.murphy@arm.com, jgg@ziepe.ca Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, kevin.tian@intel.com, dwmw2@infradead.org, will@kernel.org, lukas@wunner.de, yi.l.liu@intel.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Ethan Zhao Subject: Re: [PATCH v12 4/5] iommu/vt-d: pass pdev parameter for qi_check_fault() and refactor callers Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129034924.817005-5-haifeng.zhao@linux.intel.com> Hi Ethan, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Ethan-Zhao/PCI-make-pci_dev_is_disconnected-helper-public-for-other-drivers/20240129-115259 base: 41bccc98fb7931d63d03f326a746ac4d429c1dd3 patch link: https://lore.kernel.org/r/20240129034924.817005-5-haifeng.zhao%40linux.intel.com patch subject: [PATCH v12 4/5] iommu/vt-d: pass pdev parameter for qi_check_fault() and refactor callers config: x86_64-randconfig-161-20240207 (https://download.01.org/0day-ci/archive/20240208/202402080321.n77hu71Y-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202402080321.n77hu71Y-lkp@intel.com/ smatch warnings: drivers/iommu/intel/dmar.c:1533 qi_flush_dev_iotlb() error: we previously assumed 'info->dev' could be null (see line 1533) vim +1533 drivers/iommu/intel/dmar.c 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1522 void qi_flush_dev_iotlb(struct intel_iommu *iommu, 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1523 struct device_domain_info *info, u64 addr, 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1524 unsigned int mask) 6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1525 { c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1526 struct pci_dev *pdev = NULL; 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1527 u16 sid, qdep, pfsid; 6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1528 struct qi_desc desc; 6ba6c3a4cacfd6 drivers/pci/dmar.c Yu Zhao 2009-05-18 1529 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1530 if (!info || !info->ats_enabled) 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1531 return; 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1532 c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 @1533 if (info->dev || !dev_is_pci(info->dev)) Missing ! character. if (!info->dev c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1534 return; c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1535 c830e699e08a6c drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1536 pdev = to_pci_dev(info->dev); 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1537 sid = info->bus << 8 | info->devfn; 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1538 qdep = info->ats_qdep; 20da7293134024 drivers/iommu/intel/dmar.c Ethan Zhao 2024-01-28 1539 pfsid = info->pfsid; -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki