From: Kieran Bingham <email@example.com> To: Geert Uytterhoeven <firstname.lastname@example.org> Cc: Sergei Shtylyov <email@example.com>, Linux-Renesas <firstname.lastname@example.org>, Laurent Pinchart <email@example.com>, Geert Uytterhoeven <firstname.lastname@example.org>, David Airlie <email@example.com>, Daniel Vetter <firstname.lastname@example.org>, "open list:DRM DRIVERS FOR RENESAS" <email@example.com>, open list <firstname.lastname@example.org> Subject: Re: [PATCH] drm: rcar-du: Add r8a77980 support Date: Thu, 12 Sep 2019 13:11:37 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CAMuHMdVYqx_znkMbwCVyA6WH8-0uOotL3wXCTkvyXG1=i9Wfirstname.lastname@example.org> On 12/09/2019 13:03, Geert Uytterhoeven wrote: > Hi Kieran, > > On Thu, Sep 12, 2019 at 12:26 PM Kieran Bingham > <email@example.com> wrote: >> (pulling in +Geert for his opinion on compatible string usages) >> >> On 12/09/2019 11:00, Sergei Shtylyov wrote:> Hello! >>> On 11.09.2019 22:25, Kieran Bingham wrote: >>>> Add direct support for the r8a77980 (V3H). >>>> >>>> The V3H shares a common, compatible configuration with the r8a77970 >>>> (V3M) so that device info structure is reused. >>> >>> Do we really need to add yet another compatible in this case? >>> I just added r8a77970 to the compatible prop in the r8a77980 DT. That's why >>> a patch like this one didn't get posted by me. >> >> It's not just about the compatible string for me here, >> >> There is no indication in the driver that it supports the r8a77980, and >> no comment in the driver to explain that the r8a77980 is shared by the >> r8a77970. >> >> This patch makes that explicit at the driver. >> >> Also - I am considering sending a patch (that I've already created >> anyway) to remove the r8a77970 reference from the >> >> arch/arm64/boot/dts/renesas/r8a77980.dtsi file. >> >> This is the *only* non r8a77980 reference in this file, so it seems very >> out of place. > > Agreed. > >> In fact more so than that - except for a seemingly glaring typo, that >> I'll investigate and send a patch for next, this is the *only* cross-soc >> compatible reference: >> >> #!/bin/sh >> >> files=r8a77*.dtsi >> >> for f in $files; >> do >> soc=`basename $f .dtsi | sed 's/-.*//'` >> echo "F: $f soc: $soc"; >> >> # Find all references to all socs, then hide 'this' soc >> grep r8a77 $f | grep -v $soc > > This hides the complete line. So you better use e.g. > > sed -e "s/$soc/soc/ig" $f | grep -i r8a Aha yes, excellent point! (I'm glad I posted my working) > > instead. No new offenders, though. Phew, I still got the right answer :-D -- Kieran
next prev parent reply other threads:[~2019-09-12 12:11 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-11 19:25 Kieran Bingham 2019-09-12 10:00 ` Sergei Shtylyov 2019-09-12 10:26 ` Kieran Bingham 2019-09-12 10:45 ` Kieran Bingham 2019-09-12 12:03 ` Geert Uytterhoeven 2019-09-12 12:11 ` Kieran Bingham [this message] 2019-09-13 8:21 ` Simon Horman 2019-09-13 8:30 ` Geert Uytterhoeven 2019-09-13 8:57 ` Simon Horman 2019-09-13 9:03 ` Laurent Pinchart 2019-12-09 12:41 ` Kieran Bingham 2019-12-13 0:48 ` Laurent Pinchart 2019-12-16 9:47 ` Kieran Bingham 2019-12-16 10:37 ` Geert Uytterhoeven 2019-12-17 23:11 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] drm: rcar-du: Add r8a77980 support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).