From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A4F9C4CEC6 for ; Thu, 12 Sep 2019 12:11:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D59CD20CC7 for ; Thu, 12 Sep 2019 12:11:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="V3K7kyI+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731505AbfILMLn (ORCPT ); Thu, 12 Sep 2019 08:11:43 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54608 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730454AbfILMLn (ORCPT ); Thu, 12 Sep 2019 08:11:43 -0400 Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD4AC33A; Thu, 12 Sep 2019 14:11:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1568290301; bh=NOv4MyRD/H4sN33iCT3cWaXxofQTNOSbcc5mu90xRJ4=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=V3K7kyI+B8VIXUeBNONAh5xlpsnF22g3XbXJ2RLNyU58NmUmY2KkyNiCIO4jHepad ObfbkW0mrY7QBlxGkxM5zLpivD5h3NECfvONQQOb2Xu1UbW4NAMguOSWw3eVJLpg9p 3I4zFBb1Fgj9P5M7fOgO7BPFwOugJ9oOS9/LUom0= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH] drm: rcar-du: Add r8a77980 support To: Geert Uytterhoeven Cc: Sergei Shtylyov , Linux-Renesas , Laurent Pinchart , Geert Uytterhoeven , David Airlie , Daniel Vetter , "open list:DRM DRIVERS FOR RENESAS" , open list References: <20190911192502.16609-1-kieran.bingham+renesas@ideasonboard.com> <70b94265-69f3-d18f-1b67-b5b814723b1b@cogentembedded.com> From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Thu, 12 Sep 2019 13:11:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/2019 13:03, Geert Uytterhoeven wrote: > Hi Kieran, > > On Thu, Sep 12, 2019 at 12:26 PM Kieran Bingham > wrote: >> (pulling in +Geert for his opinion on compatible string usages) >> >> On 12/09/2019 11:00, Sergei Shtylyov wrote:> Hello! >>> On 11.09.2019 22:25, Kieran Bingham wrote: >>>> Add direct support for the r8a77980 (V3H). >>>> >>>> The V3H shares a common, compatible configuration with the r8a77970 >>>> (V3M) so that device info structure is reused. >>> >>> Do we really need to add yet another compatible in this case? >>> I just added r8a77970 to the compatible prop in the r8a77980 DT. That's why >>> a patch like this one didn't get posted by me. >> >> It's not just about the compatible string for me here, >> >> There is no indication in the driver that it supports the r8a77980, and >> no comment in the driver to explain that the r8a77980 is shared by the >> r8a77970. >> >> This patch makes that explicit at the driver. >> >> Also - I am considering sending a patch (that I've already created >> anyway) to remove the r8a77970 reference from the >> >> arch/arm64/boot/dts/renesas/r8a77980.dtsi file. >> >> This is the *only* non r8a77980 reference in this file, so it seems very >> out of place. > > Agreed. > >> In fact more so than that - except for a seemingly glaring typo, that >> I'll investigate and send a patch for next, this is the *only* cross-soc >> compatible reference: >> >> #!/bin/sh >> >> files=r8a77*.dtsi >> >> for f in $files; >> do >> soc=`basename $f .dtsi | sed 's/-.*//'` >> echo "F: $f soc: $soc"; >> >> # Find all references to all socs, then hide 'this' soc >> grep r8a77 $f | grep -v $soc > > This hides the complete line. So you better use e.g. > > sed -e "s/$soc/soc/ig" $f | grep -i r8a Aha yes, excellent point! (I'm glad I posted my working) > > instead. No new offenders, though. Phew, I still got the right answer :-D -- Kieran