From: Joe Perches <joe@perches.com>
To: Nishad Kamdar <nishadkamdar@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: NeilBrown <neil@brown.name>,
devel@driverdev.osuosl.org,
"Christian Lütke-Stetzkamp" <christian@lkamp.de>,
linux-kernel@vger.kernel.org, "John Crispin" <blogic@openwrt.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] staging: mt7621-mmc: Fix single statement macros in sd.c
Date: Sun, 23 Sep 2018 06:31:32 -0700 [thread overview]
Message-ID: <b0f415b5b9655571374ab30e37406b494d07bc45.camel@perches.com> (raw)
In-Reply-To: <20180923093805.GA20870@nishad>
On Sun, 2018-09-23 at 15:08 +0530, Nishad Kamdar wrote:
> This patch fixes a few single statement macros in sd.c.
> It converts two macros to inline functions. It removes
> five other macros and replaces their usages with calls to
> the function being called in the macro definition.
> Issue found by checkpatch.
>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
> Changes in v2:
> - Convert msdc_gate_clk() and msdc_ungate_clk() to inline functions.
> - Delete msdc_irq_restore(), msdc_vcore_on(), msdc_vcore_off(),
> msdc_vdd_on() and msdc_vdd_off() and replace their usages directly
> with calls to the function being called by these macros.
Nishad, do please look again for uses of these functions
you are changing.
Please try removing all the #if 0 blocks instead, and then
see if there are also now unused functions from those removed
blocks that could also be removed.
And Greg, if you look at this, look at the odd license of
these files.
It's possible the license is incompatible with the GPL.
next prev parent reply other threads:[~2018-09-23 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 9:38 [PATCH v2] staging: mt7621-mmc: Fix single statement macros in sd.c Nishad Kamdar
2018-09-23 13:31 ` Joe Perches [this message]
2018-09-25 16:17 ` Nishad Kamdar
2018-09-25 18:49 ` Greg Kroah-Hartman
2018-09-25 19:01 ` Joe Perches
2018-09-26 2:29 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0f415b5b9655571374ab30e37406b494d07bc45.camel@perches.com \
--to=joe@perches.com \
--cc=blogic@openwrt.org \
--cc=christian@lkamp.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=nishadkamdar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).