From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752868AbdA3Kg2 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Jan 2017 05:36:28 -0500
Received: from mail-pg0-f68.google.com ([74.125.83.68]:36724 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751737AbdA3Kfc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jan 2017 05:35:32 -0500
Subject: Re: [PATCH 2/2] perf evsel: Check for NULL before
 perf_evsel__is_bpf_output()
To: Jiri Olsa <jolsa@redhat.com>
References: <1485753819-12857-1-git-send-email-treeze.taeung@gmail.com>
 <1485753819-12857-2-git-send-email-treeze.taeung@gmail.com>
 <20170130085547.GB22029@krava>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <b10265c1-6c11-db3b-29cd-62db0a7c0b3d@gmail.com>
Date: Mon, 30 Jan 2017 19:26:30 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20170130085547.GB22029@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, jirka :)

Thank you!
Taeung

On 01/30/2017 05:55 PM, Jiri Olsa wrote:
> On Mon, Jan 30, 2017 at 02:23:39PM +0900, Taeung Song wrote:
>> If 'evsel' is NULL, in perf_evsel__is_bpf_output()
>> NULL pointer error can happen so check it.
>>
>> Cc: Jiri Olsa <jolsa@redhat.com>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>> ---
>>  tools/perf/util/evsel.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
>> index 04e536a..b77da72 100644
>> --- a/tools/perf/util/evsel.c
>> +++ b/tools/perf/util/evsel.c
>> @@ -242,8 +242,10 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx)
>>  {
>>  	struct perf_evsel *evsel = zalloc(perf_evsel__object.size);
>>
>> -	if (evsel != NULL)
>> -		perf_evsel__init(evsel, attr, idx);
>> +	if (!evsel)
>> +		return NULL;
>> +
>> +	perf_evsel__init(evsel, attr, idx);
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> thanks,
> jirka
>