From: Jiri Slaby <jirislaby@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] tty: serial: samsung: embed s3c24xx_uart_info in parent structure
Date: Mon, 7 Mar 2022 07:30:21 +0100 [thread overview]
Message-ID: <b10b87f9-2ccb-858c-dd88-5b8096acbb60@kernel.org> (raw)
In-Reply-To: <20220304080348.218581-1-krzysztof.kozlowski@canonical.com>
On 04. 03. 22, 9:03, Krzysztof Kozlowski wrote:
> Embed "struct s3c24xx_uart_info" directly as a member of "struct
> s3c24xx_serial_drv_data" instead of keeping it as a pointer. This makes
> the code clearer (obvious ownership of "struct s3c24xx_serial_drv_data")
> and saves one pointer.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/samsung_tty.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index d002a4e48ed9..aa5678d03704 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -85,7 +85,7 @@ struct s3c24xx_uart_info {
> };
>
> struct s3c24xx_serial_drv_data {
> - struct s3c24xx_uart_info *info;
> + struct s3c24xx_uart_info info;
> struct s3c2410_uartcfg *def_cfg;
> unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS];
> };
> @@ -2197,7 +2197,7 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
> }
>
> ourport->baudclk = ERR_PTR(-EINVAL);
> - ourport->info = ourport->drv_data->info;
> + ourport->info = &ourport->drv_data->info;
> ourport->cfg = (dev_get_platdata(&pdev->dev)) ?
> dev_get_platdata(&pdev->dev) :
> ourport->drv_data->def_cfg;
> @@ -2616,7 +2616,7 @@ static struct console s3c24xx_serial_console = {
>
> #ifdef CONFIG_CPU_S3C2410
> static struct s3c24xx_serial_drv_data s3c2410_serial_drv_data = {
> - .info = &(struct s3c24xx_uart_info) {
> + .info = {
> .name = "Samsung S3C2410 UART",
> .type = TYPE_S3C24XX,
> .port_type = PORT_S3C2410,
> @@ -2644,7 +2644,7 @@ static struct s3c24xx_serial_drv_data s3c2410_serial_drv_data = {
>
> #ifdef CONFIG_CPU_S3C2412
> static struct s3c24xx_serial_drv_data s3c2412_serial_drv_data = {
> - .info = &(struct s3c24xx_uart_info) {
> + .info = {
> .name = "Samsung S3C2412 UART",
> .type = TYPE_S3C24XX,
> .port_type = PORT_S3C2412,
> @@ -2674,7 +2674,7 @@ static struct s3c24xx_serial_drv_data s3c2412_serial_drv_data = {
> #if defined(CONFIG_CPU_S3C2440) || defined(CONFIG_CPU_S3C2416) || \
> defined(CONFIG_CPU_S3C2443) || defined(CONFIG_CPU_S3C2442)
> static struct s3c24xx_serial_drv_data s3c2440_serial_drv_data = {
> - .info = &(struct s3c24xx_uart_info) {
> + .info = {
> .name = "Samsung S3C2440 UART",
> .type = TYPE_S3C24XX,
> .port_type = PORT_S3C2440,
> @@ -2704,7 +2704,7 @@ static struct s3c24xx_serial_drv_data s3c2440_serial_drv_data = {
>
> #if defined(CONFIG_CPU_S3C6400) || defined(CONFIG_CPU_S3C6410)
> static struct s3c24xx_serial_drv_data s3c6400_serial_drv_data = {
> - .info = &(struct s3c24xx_uart_info) {
> + .info = {
> .name = "Samsung S3C6400 UART",
> .type = TYPE_S3C6400,
> .port_type = PORT_S3C6400,
> @@ -2733,7 +2733,7 @@ static struct s3c24xx_serial_drv_data s3c6400_serial_drv_data = {
>
> #ifdef CONFIG_CPU_S5PV210
> static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
> - .info = &(struct s3c24xx_uart_info) {
> + .info = {
> .name = "Samsung S5PV210 UART",
> .type = TYPE_S3C6400,
> .port_type = PORT_S3C6400,
> @@ -2762,7 +2762,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
>
> #if defined(CONFIG_ARCH_EXYNOS)
> #define EXYNOS_COMMON_SERIAL_DRV_DATA() \
> - .info = &(struct s3c24xx_uart_info) { \
> + .info = { \
> .name = "Samsung Exynos UART", \
> .type = TYPE_S3C6400, \
> .port_type = PORT_S3C6400, \
> @@ -2811,7 +2811,7 @@ static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = {
>
> #ifdef CONFIG_ARCH_APPLE
> static struct s3c24xx_serial_drv_data s5l_serial_drv_data = {
> - .info = &(struct s3c24xx_uart_info) {
> + .info = {
> .name = "Apple S5L UART",
> .type = TYPE_APPLE_S5L,
> .port_type = PORT_8250,
--
js
suse labs
prev parent reply other threads:[~2022-03-07 6:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 8:03 [PATCH 1/7] tty: serial: samsung: embed s3c24xx_uart_info in parent structure Krzysztof Kozlowski
2022-03-04 8:03 ` [PATCH 2/7] tty: serial: samsung: embed s3c2410_uartcfg " Krzysztof Kozlowski
2022-03-07 6:31 ` Jiri Slaby
2022-03-04 8:03 ` [PATCH 3/7] tty: serial: samsung: constify s3c24xx_serial_drv_data Krzysztof Kozlowski
2022-03-07 6:36 ` Jiri Slaby
2022-03-07 7:48 ` Krzysztof Kozlowski
2022-03-04 8:03 ` [PATCH 4/7] tty: serial: samsung: constify UART name Krzysztof Kozlowski
2022-03-07 6:36 ` Jiri Slaby
2022-03-04 8:03 ` [PATCH 5/7] tty: serial: samsung: constify s3c24xx_serial_drv_data members Krzysztof Kozlowski
2022-03-07 6:38 ` Jiri Slaby
2022-03-07 7:49 ` Krzysztof Kozlowski
2022-03-04 8:03 ` [PATCH 6/7] tty: serial: samsung: constify variables and pointers Krzysztof Kozlowski
2022-03-07 6:41 ` Jiri Slaby
2022-03-04 8:03 ` [PATCH 7/7] tty: serial: samsung: simplify getting OF match data Krzysztof Kozlowski
2022-03-07 6:30 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b10b87f9-2ccb-858c-dd88-5b8096acbb60@kernel.org \
--to=jirislaby@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).