From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4749AC433F5 for ; Wed, 8 Sep 2021 09:08:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29CF26113E for ; Wed, 8 Sep 2021 09:08:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348590AbhIHJJY (ORCPT ); Wed, 8 Sep 2021 05:09:24 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:52737 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348455AbhIHJJJ (ORCPT ); Wed, 8 Sep 2021 05:09:09 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631092082; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=8szJlKgcGuGNNeXnnIPug4EYFkWW3s0E9P2TtnxnQks=; b=U9B5NBmqikbztC4aFt8SN/q+JpNUXUGnMcy43rD3tkG3vXJZ8gsRUn0v0Y4pI3PXTkQ1oBS7 g1AT2eh8CSc0yQQ3vrzU39z5XkVFtDDSNZ9TWs2V++ONU4AkfwmNWgk6cWoe3PHqc7q1xqth FaLVbTo64SdZUQs44qITPZP/z3U= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 61387d5cb52e91333ca621f4 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 08 Sep 2021 09:07:40 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 527F9C43616; Wed, 8 Sep 2021 09:07:40 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id B0623C4338F; Wed, 8 Sep 2021 09:07:39 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 08 Sep 2021 14:37:39 +0530 From: skakit@codeaurora.org To: Matthias Kaehlcke Cc: Pavel Machek , Rob Herring , Andy Gross , Bjorn Andersson , swboyd@chromium.org, kgunda@codeaurora.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support In-Reply-To: References: <1630924867-4663-1-git-send-email-skakit@codeaurora.org> <1630924867-4663-4-git-send-email-skakit@codeaurora.org> Message-ID: X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-09-07 23:46, Matthias Kaehlcke wrote: > On Mon, Sep 06, 2021 at 04:11:07PM +0530, satya priya wrote: >> Add pwm support for PM8350C pmic. >> >> Signed-off-by: satya priya >> --- >> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> b/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> index e1b75ae..ecdae55 100644 >> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> @@ -29,6 +29,12 @@ >> interrupt-controller; >> #interrupt-cells = <2>; >> }; >> + >> + pm8350c_pwm4: pwm { > > What does the '4' represent, an internal channel number? It should > probably be omitted if the PM8350 only has a single output PWM > port. > pm8350c has four PWMs, but I think we can drop the '4' here. >> + compatible = "qcom,pm8350c-pwm"; >> + #pwm-cells = <2>; >> + status = "okay"; > > I don't think it should be enabled by default, there may be boards with > the PM8350C that don't use the PWM. Okay.