From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34217C433F5 for ; Wed, 13 Apr 2022 07:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233300AbiDMHYl (ORCPT ); Wed, 13 Apr 2022 03:24:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232967AbiDMHYh (ORCPT ); Wed, 13 Apr 2022 03:24:37 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BB7C41639 for ; Wed, 13 Apr 2022 00:22:17 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neXK8-0002PA-B8; Wed, 13 Apr 2022 09:21:56 +0200 Message-ID: Subject: Re: [PATCH v2 0/7] Add the iMX8MP PCIe support From: Lucas Stach To: Hongxing Zhu , "tharvey@gateworks.com" , Alexander Stein Cc: Philipp Zabel , "bhelgaas@google.com" , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Vinod Koul , "linux-phy@lists.infradead.org" , Device Tree Mailing List , "linux-pci@vger.kernel.org" , Linux ARM Mailing List , open list , Sascha Hauer , dl-linux-imx Date: Wed, 13 Apr 2022 09:21:53 +0200 In-Reply-To: References: <1646644054-24421-1-git-send-email-hongxing.zhu@nxp.com> <4f8f93c51fedc84d94534e962bc7c68c4a4e5616.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, Am Montag, dem 11.04.2022 um 03:32 +0000 schrieb Hongxing Zhu: > > -----Original Message----- > > From: Lucas Stach > > Sent: 2022年4月8日 16:13 > > To: Hongxing Zhu ; tharvey@gateworks.com; > > Alexander Stein > > Cc: Philipp Zabel ; bhelgaas@google.com; > > Lorenzo > > Pieralisi ; Rob Herring > > ; Shawn > > Guo ; Vinod Koul ; > > linux-phy@lists.infradead.org; Device Tree Mailing List > > ; linux-pci@vger.kernel.org; Linux ARM > > Mailing > > List ; open list > > ; Sascha Hauer > > ; > > dl-linux-imx > > Subject: Re: [PATCH v2 0/7] Add the iMX8MP PCIe support > > > > Am Freitag, dem 08.04.2022 um 03:14 +0000 schrieb Hongxing Zhu: > > > > > > [...] > > > > Richard, > > > > > > > > Thanks for working on this! > > > > > > > > Do you plan on submitting another version soon? I've tried to > > > > test > > > > this with an imx8mp board I'm bringing up and while the host > > > > controller enumerates I fail to get a link to a device. It's > > > > very > > > > likely I am missing something as this series depends on the > > > > IMX8MP blk-ctrl > > and gpc series which I also can't cleanly apply. > > > > Lucas just submitted a 'consolidated i.MX8MP HSIO/MEDIA/HDMI > > > > blk-ctrl series' [1] yet I can't find a repo/branch that > > > > applies to either. > > > > > > > > Perhaps you have a git repo somewhere I can look at while we > > > > wait > > > > for imx8mp blk-ctl/gpc to settle and you to submit a v3? > > > Hi Tim: > > > Thanks for your kindly help to do the tests. > > > I had listed the dependencies in the cover-letter log. > > > Alexander and I used to test this series commits based on the > > > V5.17 kernel. > > > > > > Lucas had provided some review comments and suggestions about the > > > PLL > > > bits > > >  manipulations of HSIOMIX in i.MX8MP PCIe PHY driver #3 of this > > > series. > > > And he suggested to let the HSIOMIX blk-ctrl make this PLL as a > > > real > > > clock, > > >  and used by i.MX8MP PCIe PHY driver later. > > > > > > Although I have some confusions, it's better let's wating for the > > > blk-ctrl settle down and get clear discussion with Lucas later. > > > How do you think about that? > > > > Just to let you know my plans: I was quite busy with getting the > > i.MX8MP > > HDMI part to work. Now that this is at least in a state where it > > can collect > > some feedback from upstream I have some time to circle back to this > > topic. I > > can't commit to do it immediately, but I'll get around to looking > > at the PCIe > > series a bit more in-depth and apply my HSIO PLL suggestion to the > > blk-ctrl > > driver during the next week. > > Hi Lucas: > Thanks for your helpful reply. > I know that you're busy with the blk-ctrl settle down now, and had > explained to > Tim. Yesterday I tried to get this series working on my 8MP-EVK board, but was unsuccessful for now. The PCIe link does not come up. PCIe REF_CLK is present and PERST de-asserted. I'm not sure if this is due to a faulty EP device (I don't have another M.2 KeyE device around to check) or if this may be due to the old revision of my 8MP-EVK, as I'm still working with a RevA board. The schematic revision log doesn't show anything that would obviously influence PCIe operation, but I have also not found any schematics for RevA. Do you know if there have been any PCIe related changes/fixes in the later EVK board revisions? For now I'll try to get this working on a custom i.MX8MP board, where I can use a different EP device. Maybe I'll have a bit more luck there. Regards, Lucas