linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH linux-next] macintosh: fix warning comparing pointer to 0
@ 2021-08-20  2:34 jing yangyang
  2022-03-15 10:09 ` Christophe Leroy
  0 siblings, 1 reply; 2+ messages in thread
From: jing yangyang @ 2021-08-20  2:34 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: linuxppc-dev, linux-kernel, jing yangyang, Zeal Robot

Fix the following coccicheck warning:

./drivers/macintosh/windfarm_pm91.c:152:12-13:WARNING comparing pointer to 0

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
---
 drivers/macintosh/windfarm_pm91.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c
index 3f346af..568f8a2 100644
--- a/drivers/macintosh/windfarm_pm91.c
+++ b/drivers/macintosh/windfarm_pm91.c
@@ -149,7 +149,7 @@ static void wf_smu_create_cpu_fans(void)
 
 	/* First, locate the PID params in SMU SBD */
 	hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
-	if (hdr == 0) {
+	if (!hdr) {
 		printk(KERN_WARNING "windfarm: CPU PID fan config not found "
 		       "max fan speed\n");
 		goto fail;
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] macintosh: fix warning comparing pointer to 0
  2021-08-20  2:34 [PATCH linux-next] macintosh: fix warning comparing pointer to 0 jing yangyang
@ 2022-03-15 10:09 ` Christophe Leroy
  0 siblings, 0 replies; 2+ messages in thread
From: Christophe Leroy @ 2022-03-15 10:09 UTC (permalink / raw)
  To: jing yangyang, Benjamin Herrenschmidt
  Cc: Zeal Robot, linuxppc-dev, linux-kernel, jing yangyang



Le 20/08/2021 à 04:34, jing yangyang a écrit :
> Fix the following coccicheck warning:
> 
> ./drivers/macintosh/windfarm_pm91.c:152:12-13:WARNING comparing pointer to 0
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>

WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address 
mismatch: 'From: jing yangyang <cgel.zte@gmail.com>' != 'Signed-off-by: 
jing yangyang <jing.yangyang@zte.com.cn>'

Please resend.

Thanks
Christophe


> ---
>   drivers/macintosh/windfarm_pm91.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c
> index 3f346af..568f8a2 100644
> --- a/drivers/macintosh/windfarm_pm91.c
> +++ b/drivers/macintosh/windfarm_pm91.c
> @@ -149,7 +149,7 @@ static void wf_smu_create_cpu_fans(void)
>   
>   	/* First, locate the PID params in SMU SBD */
>   	hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
> -	if (hdr == 0) {
> +	if (!hdr) {
>   		printk(KERN_WARNING "windfarm: CPU PID fan config not found "
>   		       "max fan speed\n");
>   		goto fail;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-15 10:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20  2:34 [PATCH linux-next] macintosh: fix warning comparing pointer to 0 jing yangyang
2022-03-15 10:09 ` Christophe Leroy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).