From: Paolo Bonzini <pbonzini@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
Sean Christopherson <seanjc@google.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: SEV: Return appropriate error codes if SEV-ES scratch setup fails
Date: Thu, 11 Nov 2021 16:47:33 +0100 [thread overview]
Message-ID: <b13cdd98-52b7-f70b-5aad-5f8ca6413bc0@redhat.com> (raw)
In-Reply-To: <fc56edb6-5154-4532-242f-4acb8b448330@amd.com>
On 11/11/21 16:14, Tom Lendacky wrote:
>
>> Return appropriate error codes if setting up the GHCB scratch area for an
>> SEV-ES guest fails. In particular, returning -EINVAL instead of -ENOMEM
>> when allocating the kernel buffer could be confusing as userspace would
>> likely suspect a guest issue.
>
> Based on previous feedback and to implement the changes to the GHCB
> specification, I'm planning on submitting a patch that will return an
> error code back to the guest, instead of terminating the guest, if the
> scratch area fails to be setup properly. So you could hold off on this
> patch if you want.
I think we still want these two patches in 5.16.
Paolo
next prev parent reply other threads:[~2021-11-11 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 22:23 [PATCH 0/2] KVM: SEV: Fall back to __vmalloc() for SEV-ES scratch Sean Christopherson
2021-11-09 22:23 ` [PATCH 1/2] KVM: SEV: Return appropriate error codes if SEV-ES scratch setup fails Sean Christopherson
2021-11-11 15:14 ` Tom Lendacky
2021-11-11 15:47 ` Paolo Bonzini [this message]
2021-11-11 15:56 ` Tom Lendacky
2021-11-09 22:23 ` [PATCH 2/2] KVM: SEV: Fall back to __vmalloc() for SEV-ES scratch area if necessary Sean Christopherson
2021-11-11 12:52 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b13cdd98-52b7-f70b-5aad-5f8ca6413bc0@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).