From: Yunfeng Ye <yeyunfeng@huawei.com>
To: Vlastimil Babka <vbabka@suse.cz>,
Tang Yizhou <tangyizhou@huawei.com>, <cl@linux.com>,
<penberg@kernel.org>, <rientjes@google.com>,
<iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Cc: <jhubbard@nvidia.com>, <songmuchun@bytedance.com>,
<willy@infradead.org>, <wuxu.wu@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: [PATCH v2] mm, slub: emit the "free" trace report before freeing memory in kmem_cache_free()
Date: Wed, 3 Nov 2021 11:39:40 +0800 [thread overview]
Message-ID: <b15e0bd0-14f3-3fd3-87a5-fe1b0889ad0b@huawei.com> (raw)
In-Reply-To: <5f3b17ae-bff5-fd0f-cd1e-fa481f100149@suse.cz>
On 2021/11/2 22:39, Vlastimil Babka wrote:
> On 11/2/21 14:53, Tang Yizhou wrote:
>> On 2021/11/2 19:43, Yunfeng Ye wrote:
>>> --- a/mm/slub.c
>>> +++ b/mm/slub.c
>>> @@ -3526,8 +3526,8 @@ void kmem_cache_free(struct kmem_cache *s, void *x)
>>> s = cache_from_obj(s, x);
>>> if (!s)
>>> return;
>>> - slab_free(s, virt_to_head_page(x), x, NULL, 1, _RET_IP_);
>>> trace_kmem_cache_free(_RET_IP_, x, s->name);
>>> + slab_free(s, virt_to_head_page(x), x, NULL, 1, _RET_IP_);
>>> }
>>
>> It seems that kmem_cache_free() in mm/slab.c has the same problem.
>> We can fix it. Thanks.
>
> Doh, true. Should go best before the local_irq_save() there.
> And also kmem_cache_free() in mm/slob.c.
>
Yes, I will fix the same problem together in the v3 patch.
Thanks.
> Interestingly kfree() is already OK in all 3 implementations.
>
>>> EXPORT_SYMBOL(kmem_cache_free);
>>>
>>
>
> .
>
next prev parent reply other threads:[~2021-11-03 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 11:43 [PATCH v2] mm, slub: emit the "free" trace report before freeing memory in kmem_cache_free() Yunfeng Ye
2021-11-02 13:53 ` Tang Yizhou
2021-11-02 14:39 ` Vlastimil Babka
2021-11-03 3:39 ` Yunfeng Ye [this message]
2021-11-02 18:37 ` John Hubbard
2021-11-03 3:41 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b15e0bd0-14f3-3fd3-87a5-fe1b0889ad0b@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hewenliang4@huawei.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=songmuchun@bytedance.com \
--cc=tangyizhou@huawei.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=wuxu.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).