From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816BCC3524F for ; Tue, 4 Feb 2020 09:51:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48E67217BA for ; Tue, 4 Feb 2020 09:51:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="HK499qij" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbgBDJvF (ORCPT ); Tue, 4 Feb 2020 04:51:05 -0500 Received: from lb1-smtp-cloud7.xs4all.net ([194.109.24.24]:46633 "EHLO lb1-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726343AbgBDJvE (ORCPT ); Tue, 4 Feb 2020 04:51:04 -0500 Received: from [IPv6:2001:420:44c1:2577:c522:bb58:9147:43ff] ([IPv6:2001:420:44c1:2577:c522:bb58:9147:43ff]) by smtp-cloud7.xs4all.net with ESMTPA id yurBiQflTVuxOyurFiI8yZ; Tue, 04 Feb 2020 10:51:01 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1; t=1580809861; bh=udrDG7W7XxVlZg9dFBjVJa1SeinJFWf8PYu2s1ZBzEE=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=HK499qijLMt0d3NsJ/R6CALFLgIH5TPDKLVv3JotVW7E7jZ07nDX/u+G3KPwDGiya 4vO23Pn04jCbJi6EvdQs9zHPgm/gaq7SPu1V1vcxUy6lHQbMxg4I6sahHsRi+zfTQj OlBSokrE5w+DUmlQcCjjnkKOK2C+brr7gVNvAFop+zpL5UXbuooWaXd0/JdVlheRAT WSE2ytobns3p7mUHPWFQ+eBzzs54fwXOfF4uZDMWcwgm/kMPMz44GEH+lILGNNy1wB BdYCKaK1svlIxvF8PyWmJJvrOHO6jzJ4YgYSL2nFmktclMlk08Wo+AM9lmyPf7R+DP KlTsvzXhDJ6uA== Subject: Re: [RFC PATCH v1 0/5] Add Tegra driver for video capture To: Thierry Reding Cc: Sowjanya Komatineni , jonathanh@nvidia.com, frankc@nvidia.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1580235801-4129-1-git-send-email-skomatineni@nvidia.com> <20200130154246.GA2904678@ulmo> <8654e6fd-c403-6e68-e5cf-09297b5d8b5d@xs4all.nl> <20200131170351.GA3444092@ulmo> From: Hans Verkuil Message-ID: Date: Tue, 4 Feb 2020 10:50:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200131170351.GA3444092@ulmo> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfE57kH2nPdi6RuL5Tj6iVOgBB0zQcKUPr7DSyqTUxljwxpmmpytfaq19V/tG1nCy/2R9YUpxBlmWXq14r7ylSGpMXGwLU42dekPcaxldoLur6pV9KZyV bmZ3MXgxDSVJZDaKgt7TNK5D66zRoiaCRZX5ad8dvMCxEXluNKfGp5uFyV/FQYVU142nJVOFaH08xF2mBEqHFhjdE40AvLtxGARg3NkLqb4QAmPq7yJibDpd jbYvK+HxyYndRWamV7nImM/+YIe0B2UCXpV6EZYNAnC4mOl9kUte1dh5SLAr3gofV2EZC7tm/sSsMnI0nhbNf21TWdbNVNnypNqOyypbnfhnjQnjLrGOtt5z tI6TLNg3Ay3dhmS4IsjnfvfaJSyYMWgrFOGIwXRD5gmihhhAXZzUSZbJwyZoGamDeTKx6nnP8koFBr1Z+lrwCtO62ecn3QYrRGS0WPqTLjct/wdBuGrVD6Tx KZogcjGuaBQxB6g1SerbtTxl7YLyikSGJnSr1cgzLspZhnYRBQ+lgkqSKEia61J+FK2Yc5aVd0iwOep+TuQHNmUjKWZt9RJG4i9OvrbsZGroHLFI3iqtPTIr BT8= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/20 6:03 PM, Thierry Reding wrote: > On Fri, Jan 31, 2020 at 03:29:52PM +0100, Hans Verkuil wrote: >> On 1/30/20 4:42 PM, Thierry Reding wrote: >>> On Thu, Jan 30, 2020 at 03:41:50PM +0100, Hans Verkuil wrote: >>>> Hi Sowjanya, >>>> >>>> On 1/28/20 7:23 PM, Sowjanya Komatineni wrote: >>>>> This series adds Tegra210 VI and CSI driver for built-in test pattern >>>>> generator (TPG) capture. >>>>> >>>>> Tegra210 supports max 6 channels on VI and 6 ports on CSI where each >>>>> CSI port is one-to-one mapped to VI channel for video capture. >>>>> >>>>> This series has TPG support only where it creates hard media links >>>>> between CSI subdevice and VI video device without device graphs. >>>>> >>>>> v4l2-compliance results are available below the patch diff. >>>>> >>>>> [v0]: Includes, >>>>> - Adds CSI TPG clock to Tegra210 clock driver >>>>> - Host1x video driver with VI and CSI clients. >>>>> - Support for Tegra210 only. >>>>> - VI CSI TPG support with hard media links in driver. >>>>> - Video formats supported by Tegra210 VI >>>>> - CSI TPG supported video formats >>>> >>>> I'm trying to compile this patch series using the media_tree master >>>> branch (https://git.linuxtv.org//media_tree.git), but it fails: >>>> >>>> drivers/staging/media/tegra/tegra-channel.c: In function ‘tegra_channel_queue_setup’: >>>> drivers/staging/media/tegra/tegra-channel.c:71:15: warning: unused variable ‘count’ [-Wunused-variable] >>>> 71 | unsigned int count = *nbuffers; >>>> | ^~~~~ >>>> drivers/staging/media/tegra/tegra-channel.c: In function ‘tegra_channel_init’: >>>> drivers/staging/media/tegra/tegra-channel.c:518:55: error: ‘struct host1x_client’ has no member named ‘host’ >>>> 518 | struct tegra_camera *cam = dev_get_drvdata(vi->client.host); >>>> | ^ >>>> make[4]: *** [scripts/Makefile.build:265: drivers/staging/media/tegra/tegra-channel.o] Error 1 >>>> make[4]: *** Waiting for unfinished jobs.... >>>> drivers/staging/media/tegra/tegra-vi.c: In function ‘tegra_vi_tpg_graph_init’: >>>> drivers/staging/media/tegra/tegra-vi.c:157:55: error: ‘struct host1x_client’ has no member named ‘host’ >>>> 157 | struct tegra_camera *cam = dev_get_drvdata(vi->client.host); >>>> | ^ >>>> drivers/staging/media/tegra/tegra-vi.c: In function ‘tegra_vi_init’: >>>> drivers/staging/media/tegra/tegra-csi.c: In function ‘tegra_csi_init’: >>>> drivers/staging/media/tegra/tegra-vi.c:213:51: error: ‘struct host1x_client’ has no member named ‘host’ >>>> 213 | struct tegra_camera *cam = dev_get_drvdata(client->host); >>>> | ^~ >>>> drivers/staging/media/tegra/tegra-csi.c:259:51: error: ‘struct host1x_client’ has no member named ‘host’ >>>> 259 | struct tegra_camera *cam = dev_get_drvdata(client->host); >>>> | ^~ >>>> drivers/staging/media/tegra/tegra-vi.c: In function ‘tegra_vi_exit’: >>>> drivers/staging/media/tegra/tegra-vi.c:246:51: error: ‘struct host1x_client’ has no member named ‘host’ >>>> 246 | struct tegra_camera *cam = dev_get_drvdata(client->host); >>>> | ^~ >>>> drivers/staging/media/tegra/tegra-csi.c: In function ‘tegra_csi_exit’: >>>> drivers/staging/media/tegra/tegra-csi.c:286:51: error: ‘struct host1x_client’ has no member named ‘host’ >>>> 286 | struct tegra_camera *cam = dev_get_drvdata(client->host); >>>> | ^~ >>>> >>>> And indeed, struct host1x_client as defined in include/linux/host1x.h doesn't >>>> have a 'host' field. >>>> >>>> Does this series depend on another patch that's not yet in mainline? >>> >>> Sowjanya's been working on top of linux-next, so, yes, this patch >>> depends on a change that's been merged into the DRM tree for v5.6-rc1. >>> >>> Thierry >>> >> >> Is there a specific linux-next tag that works? I tried next-20200131 but that >> failed to boot. Same problem with the mainline repo since the host1x patches >> were merged yesterday. It compiles fine, but the boot just stops. Or am I >> missing some kernel config that is now important to have? > > linux-next and mainline are currently regressing on Tegra210 (and some > Tegra124) boards. I just sent out a series that fixes the regression for > me: > > http://patchwork.ozlabs.org/project/linux-tegra/list/?series=156215 > > Please test if this works for you. If so, I'll send this to Dave as soon > as possible. Tested-by: Hans Verkuil Thank you, now it boots on mainline + this series + the new VI/CSI driver. Regards, Hans > > Thierry >