From: Hans de Goede <hdegoede@redhat.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/2] extcon: axp288: Move to swnodes
Date: Sun, 6 Oct 2019 21:37:25 +0200 [thread overview]
Message-ID: <b1691d61-313c-ad57-3ef4-2dc2dc8263a2@redhat.com> (raw)
In-Reply-To: <20191001105138.73036-1-heikki.krogerus@linux.intel.com>
Hi,
On 01-10-2019 12:51, Heikki Krogerus wrote:
> Hi Hans,
>
> That AXP288 extcon driver is the last that uses build-in connection
> description. I'm replacing it with a code that finds the role mux
> software node instead.
>
> I'm proposing also here a little helper
> usb_role_switch_find_by_fwnode() that uses
> class_find_device_by_fwnode() to find the role switches.
I'm building a kernel with these patches to test them now
(on hw which uses the axp288 extcon code-paths with the role-sw)
No test results yet, but I did notice this will building:
CC [M] drivers/extcon/extcon-axp288.o
drivers/extcon/extcon-axp288.c: In function ‘axp288_extcon_find_role_sw’:
drivers/extcon/extcon-axp288.c:333:9: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
333 | swnode = software_node_find_by_name(NULL, "intel-xhci-usb-sw");
| ^
Regards,
Hans
next prev parent reply other threads:[~2019-10-06 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 10:51 [PATCH 0/2] extcon: axp288: Move to swnodes Heikki Krogerus
2019-10-01 10:51 ` [PATCH 1/2] usb: roles: Add usb_role_switch_find_by_fwnode() Heikki Krogerus
2019-10-01 10:51 ` [PATCH 2/2] extcon: axp288: Remove the build-in connection description Heikki Krogerus
2019-10-06 19:37 ` Hans de Goede [this message]
2019-10-08 11:15 ` [PATCH 0/2] extcon: axp288: Move to swnodes Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1691d61-313c-ad57-3ef4-2dc2dc8263a2@redhat.com \
--to=hdegoede@redhat.com \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).