From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47414C433F5 for ; Fri, 22 Oct 2021 15:39:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2575861284 for ; Fri, 22 Oct 2021 15:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233354AbhJVPl5 (ORCPT ); Fri, 22 Oct 2021 11:41:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21813 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233222AbhJVPl4 (ORCPT ); Fri, 22 Oct 2021 11:41:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634917178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKwUK85QUS5UvGDvhSdm0UayuQZWDZ03hElSfZLYkFI=; b=Hl1g7q72ig7wke6mcio1Kols026+b8YCtU9VkCV/pvcPx/1phOGQVoFbAC6EQ3Jg+qB9+I KtDQdd+MzvOnTiAxkwTAwVbiRY5LVmoy1o2O0e1cRxGlxlozI2vE5AOuFib/7OEoPaZ9V/ 1etKAvxdXP2ynQ0BDKfze0JVM4Yin58= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-Ueq-nJDMO02g3l7HjQastQ-1; Fri, 22 Oct 2021 11:39:35 -0400 X-MC-Unique: Ueq-nJDMO02g3l7HjQastQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DAB81806688; Fri, 22 Oct 2021 15:39:33 +0000 (UTC) Received: from starship (unknown [10.40.192.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF7AA10016F2; Fri, 22 Oct 2021 15:39:30 +0000 (UTC) Message-ID: Subject: Re: [PATCH 1/3] KVM: x86/mmu: Drop a redundant, broken remote TLB flush From: Maxim Levitsky To: Sean Christopherson , Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Maciej S . Szmigiero" , Ben Gardon Date: Fri, 22 Oct 2021 18:39:29 +0300 In-Reply-To: <20211022010005.1454978-2-seanjc@google.com> References: <20211022010005.1454978-1-seanjc@google.com> <20211022010005.1454978-2-seanjc@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-10-21 at 18:00 -0700, Sean Christopherson wrote: > A recent commit to fix the calls to kvm_flush_remote_tlbs_with_address() > in kvm_zap_gfn_range() inadvertantly added yet another flush instead of > fixing the existing flush. Drop the redundant flush, and fix the params > for the existing flush. > > Fixes: 2822da446640 ("KVM: x86/mmu: fix parameters to kvm_flush_remote_tlbs_with_address") > Cc: Maxim Levitsky > Cc: Maciej S. Szmigiero > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/mmu/mmu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index c6ddb042b281..f82b192bba0b 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -5709,13 +5709,11 @@ void kvm_zap_gfn_range(struct kvm *kvm, gfn_t gfn_start, gfn_t gfn_end) > for (i = 0; i < KVM_ADDRESS_SPACE_NUM; i++) > flush = kvm_tdp_mmu_zap_gfn_range(kvm, i, gfn_start, > gfn_end, flush); > - if (flush) > - kvm_flush_remote_tlbs_with_address(kvm, gfn_start, > - gfn_end - gfn_start); > } > > if (flush) > - kvm_flush_remote_tlbs_with_address(kvm, gfn_start, gfn_end); > + kvm_flush_remote_tlbs_with_address(kvm, gfn_start, > + gfn_end - gfn_start); > > kvm_dec_notifier_count(kvm, gfn_start, gfn_end); > Opps, I didn't notice that the revert added back another flush. I probablyhaven't had the revert in place when I wrote the patch that fixed parameters to kvm_flush_remote_tlbs_with_address. Best regards, Maxim Levitsky