From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A6FC5DF62 for ; Wed, 6 Nov 2019 13:44:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 869412166E for ; Wed, 6 Nov 2019 13:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731453AbfKFNo4 (ORCPT ); Wed, 6 Nov 2019 08:44:56 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:34756 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726673AbfKFNo4 (ORCPT ); Wed, 6 Nov 2019 08:44:56 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id DB34B26D9C0 Message-ID: Subject: Re: [PATCH v9 1/4] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format From: Ezequiel Garcia To: Helen Koike , "Hans Verkuil (hansverk)" , "linux-rockchip@lists.infradead.org" Cc: "linux-media@vger.kernel.org" , "eddie.cai.linux@gmail.com" , "mchehab@kernel.org" , "heiko@sntech.de" , "gregkh@linuxfoundation.org" , "jeffy.chen@rock-chips.com" , "zyc@rock-chips.com" , "linux-kernel@vger.kernel.org" , "tfiga@chromium.org" , "hans.verkuil@cisco.com" , "laurent.pinchart@ideasonboard.com" , "sakari.ailus@linux.intel.com" , "kernel@collabora.com" , "linux-arm-kernel@lists.infradead.org" , "zhengsq@rock-chips.com" , Jacob Chen Date: Wed, 06 Nov 2019 10:44:43 -0300 In-Reply-To: <28cff7ab-ef56-791e-0342-571f64cb9807@collabora.com> References: <20191106120132.6876-1-helen.koike@collabora.com> <20191106120132.6876-2-helen.koike@collabora.com> <9102bcf8-0279-7972-daff-b15aaf98804d@cisco.com> <28cff7ab-ef56-791e-0342-571f64cb9807@collabora.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, Helen: On Wed, 2019-11-06 at 09:30 -0300, Helen Koike wrote: > > On 11/6/19 10:22 AM, Hans Verkuil (hansverk) wrote: > > On 11/6/19 1:01 PM, Helen Koike wrote: > > > From: Shunqian Zheng > > > > > > Add the Rockchip ISP1 specific processing parameter format > > > V4L2_META_FMT_RK_ISP1_PARAMS and metadata format > > > V4L2_META_FMT_RK_ISP1_STAT_3A for 3A. > > > > > > Signed-off-by: Shunqian Zheng > > > Signed-off-by: Jacob Chen > > > Acked-by: Hans Verkuil > > > > I acked this? It is missing documentation for these new formats. > > I think so https://www.spinics.net/lists/linux-rockchip/msg18999.html :) > > I'll update the docs and the fixes you pointed below. > > Thanks. > Helen > > > > [refactored for upstream] > > > Signed-off-by: Helen Koike > > > Reviewed-by: Laurent Pinchart > > > > > > --- > > > > > > Changes in v9: > > > - Add reviewed-by tag from Laurent > > > > > > Changes in v8: None > > > Changes in v7: > > > - s/IPU3/RK_ISP1 > > > > > > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > > > include/uapi/linux/videodev2.h | 4 ++++ > > > 2 files changed, 6 insertions(+) > > > > > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > > > index 315ac12c3e0a..ade990554caf 100644 > > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > > @@ -1341,6 +1341,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > > > case V4L2_META_FMT_UVC: descr = "UVC Payload Header Metadata"; break; > > > case V4L2_META_FMT_D4XX: descr = "Intel D4xx UVC Metadata"; break; > > > case V4L2_META_FMT_VIVID: descr = "Vivid Metadata"; break; > > > + case V4L2_META_FMT_RK_ISP1_PARAMS: descr = "Rockchip ISP1 3A params"; break; > > > > params -> Params > > > > > + case V4L2_META_FMT_RK_ISP1_STAT_3A: descr = "Rockchip ISP1 3A statistics"; break; > > > > statistics -> Statistics > > > > > > > > default: > > > /* Compressed formats */ > > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > > index f98bbcced8ff..56798b09cd85 100644 > > > --- a/include/uapi/linux/videodev2.h > > > +++ b/include/uapi/linux/videodev2.h Can we avoid touching videodev2.h, as we did for the stateless codec pixfmts? Thanks, Ezequiel > > > @@ -762,6 +762,10 @@ struct v4l2_pix_format { > > > #define V4L2_META_FMT_D4XX v4l2_fourcc('D', '4', 'X', 'X') /* D4XX Payload Header metadata */ > > > #define V4L2_META_FMT_VIVID v4l2_fourcc('V', 'I', 'V', 'D') /* Vivid Metadata */ > > > > > > +/* Vendor specific - used for RK_ISP1 camera sub-system */ > > > +#define V4L2_META_FMT_RK_ISP1_PARAMS v4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 params */ > > > +#define V4L2_META_FMT_RK_ISP1_STAT_3A v4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A statistics */ > > > + > > > /* priv field value to indicates that subsequent fields are valid. */ > > > #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe > > > > > > > > > > Regards, > > > > Hans > >