From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A11EECE562 for ; Sat, 22 Sep 2018 02:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C64EA21569 for ; Sat, 22 Sep 2018 02:29:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="ltBWC4D1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C64EA21569 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726047AbeIVIVl (ORCPT ); Sat, 22 Sep 2018 04:21:41 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46578 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbeIVIVk (ORCPT ); Sat, 22 Sep 2018 04:21:40 -0400 Received: by mail-pg1-f194.google.com with SMTP id b129-v6so6809569pga.13 for ; Fri, 21 Sep 2018 19:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GcNLB+YtZFGEqQrGiujLOYSVXkHIzNgch1okFqFaDiY=; b=ltBWC4D1HBoEilJRtwQCtcZE+RMQW55nzzD92WHqXkSNiGBkQWg/M3zDqrS5C7TIrw prZOimq7wp5sEVIMlHIgad0FrEqUOg8JvlUkuQO7V57ZtdN6KlYzCSy62aD4XuKGSDf8 vhJ86cb7oGy2cWH5HHKSxDnh3Tk7Gr26RHp/3Qo7ghgoAPqntdpwMLCQ/87MQxDzPs0w S5kC6OKsmZzXhpktPRmY2k4KTRNGXFGSzKdMxo3PPIpfgS2sLbNCJygeu0iBYQUL7kXv b6+VIiUaNOAv9iNxRS+XwOnV6+Fu9cmE08fioO9NzbOPhg2Dt0fkfTDtR2fumB1mzaXG BRmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GcNLB+YtZFGEqQrGiujLOYSVXkHIzNgch1okFqFaDiY=; b=ZbzNGdQYUDPEQk+FFrXtdtHVXNJ+scHJtFmDF7huQgNjmLNOt4rYNS9YgShH7xtw0d 047zO23OF0pPi/cjbGlY9QkRjyUAoPchXMoW9H7+kmr5q0Y/sR0KSG/YC9z07BeFwTG6 CkgYMx5gUnmBzwJqPacfeDb1BoDPZga1wC/VH5NAp8QZqo11nyGQT1T3W/FdN9hGuoBr pfYgVPnczL4prBomyhLDaIjpdG7ncu2PyEBUdfnhrCPbJwnH2QAqLjLn4OhzrathgYpj 5O/M3+KV1vcGxWu3LOMFT+nDYmdTYRKHXfCnKosWXAAXb5RUEcPB87tKmSF4lEVRMPaZ kgpA== X-Gm-Message-State: ABuFfoiq1/Q3NHh6eWbZbRGxU8xwdZu1GuJyjRoJTC5NvnzWDJPsMs6k aKUgIH8WmKgrtwDCPm8zpisb0Rqk18o= X-Google-Smtp-Source: ACcGV632WfrdJUg7xshR1Ak8mPfkPVBkuCsgyHidnFaBx5tdFzFcedPSrM3hsfNZW/sZnPMdD/R8WA== X-Received: by 2002:a63:6445:: with SMTP id y66-v6mr370264pgb.443.1537583394225; Fri, 21 Sep 2018 19:29:54 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.22.static.utbb.net. [107.191.0.22]) by smtp.gmail.com with ESMTPSA id d22-v6sm67534549pfm.48.2018.09.21.19.29.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 19:29:53 -0700 (PDT) Subject: Re: [PATCH v3 00/12] block: always associate blkg and refcount cleanup To: Dennis Zhou Cc: Tejun Heo , Johannes Weiner , Josef Bacik , kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180911184137.35897-1-dennisszhou@gmail.com> <20180921205640.GA50648@dennisz-mbp.dhcp.thefacebook.com> From: Jens Axboe Message-ID: Date: Fri, 21 Sep 2018 20:29:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180921205640.GA50648@dennisz-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/21/18 2:56 PM, Dennis Zhou wrote: > Hi Jens, > > On Tue, Sep 11, 2018 at 02:41:25PM -0400, Dennis Zhou wrote: >> Hi everyone, >> >> v3: a few minor fixes. >> 0003: Updated the comment to bio_associate_blkg to reflect closest >> association. >> Removed a return branch in __bio_lookup_create. >> 0009: Removed an unnecessary rcu_read_(un)lock pair. >> 0010: Fixed blkg null pointer... blkg->blkcg => blkcg. >> >> This is rebased onto axboe#for-4.20/block 902d53914f64. >> >> From v2 below (updated): >> ------ >> This is a followup to the patch series I sent out earlier [1] containing >> the middle two points: >> 1. always associate a bio with a blkg >> 2. remove the extra css ref held by bios and utilize the blkg ref >> >> The major difference with v2 is that error handling on blkg creation >> and association failure is handled more gracefully. Rather than having >> the complex logic to fallback to root, failures walk up the blkg tree. >> This seems more natural and less prone to error with the many possible >> failure scenarios. >> >> Additionally, there are fixes for kbuild errors and some key details >> overlooked by me in the first series that were pointed out in review. >> >> Modified from the first patchset: >> First, both blk-throttle and blk-iolatency rely on blkg association >> to enable their policies. Rather than each policy (and future policies) >> implement this logic independently, this consolidates it such that >> all bios are tagged with a blkg. >> >> Second, with the addition of always having a blkg reference, the blkcg >> can now be referenced through it rather than maintaining an additional >> pointer and reference. So let's clean this up. >> >> [1] https://lore.kernel.org/lkml/20180831015356.69796-1-dennisszhou@gmail.com/T >> >> This patchset contains the following 12 patches: >> 0001-blkcg-fix-ref-count-issue-with-bio_blkcg-using-task_.patch >> 0002-blkcg-update-blkg_lookup_create-to-do-locking.patch >> 0003-blkcg-convert-blkg_lookup_create-to-find-closest-blk.patch >> 0004-blkcg-always-associate-a-bio-with-a-blkg.patch >> 0005-blkcg-consolidate-bio_issue_init-to-be-a-part-of-cor.patch >> 0006-blkcg-associate-a-blkg-for-pages-being-evicted-by-sw.patch >> 0007-blkcg-associate-writeback-bios-with-a-blkg.patch >> 0008-blkcg-remove-bio-bi_css-and-instead-use-bio-bi_blkg.patch >> 0009-blkcg-remove-additional-reference-to-the-css.patch >> 0010-blkcg-cleanup-and-make-blk_get_rl-use-blkg_lookup_cr.patch >> 0011-blkcg-change-blkg-reference-counting-to-use-percpu_r.patch >> 0012-blkcg-rename-blkg_try_get-to-blkg_tryget.patch >> >> This patchset is on top of axboe#for-4.20/block 902d53914f64. >> >> diffstats below: >> >> Dennis Zhou (Facebook) (12): >> blkcg: fix ref count issue with bio_blkcg using task_css >> blkcg: update blkg_lookup_create to do locking >> blkcg: convert blkg_lookup_create to find closest blkg >> blkcg: always associate a bio with a blkg >> blkcg: consolidate bio_issue_init to be a part of core >> blkcg: associate a blkg for pages being evicted by swap >> blkcg: associate writeback bios with a blkg >> blkcg: remove bio->bi_css and instead use bio->bi_blkg >> blkcg: remove additional reference to the css >> blkcg: cleanup and make blk_get_rl use blkg_lookup_create >> blkcg: change blkg reference counting to use percpu_ref >> blkcg: rename blkg_try_get to blkg_tryget >> >> Documentation/admin-guide/cgroup-v2.rst | 8 +- >> block/bfq-cgroup.c | 4 +- >> block/bfq-iosched.c | 2 +- >> block/bio.c | 158 ++++++++++++++++-------- >> block/blk-cgroup.c | 123 ++++++++++++------ >> block/blk-iolatency.c | 26 +--- >> block/blk-throttle.c | 13 +- >> block/bounce.c | 4 +- >> block/cfq-iosched.c | 4 +- >> drivers/block/loop.c | 5 +- >> drivers/md/raid0.c | 2 +- >> fs/buffer.c | 10 +- >> fs/ext4/page-io.c | 2 +- >> include/linux/bio.h | 23 ++-- >> include/linux/blk-cgroup.h | 145 +++++++++++++++------- >> include/linux/blk_types.h | 1 - >> include/linux/cgroup.h | 2 + >> include/linux/writeback.h | 5 +- >> kernel/cgroup/cgroup.c | 48 +++++-- >> kernel/trace/blktrace.c | 4 +- >> mm/page_io.c | 2 +- >> 21 files changed, 381 insertions(+), 210 deletions(-) >> >> Thanks, >> Dennis > > I reran some basic test again for sanity and it seems to be fine on my > end. There are at least acks, and some reviewed-by's on the series. Is > there anything else you think needs to be done before we let this bake > in for-4.20/for-next? Looks like it's good to go, I have applied it for 4.20. Thanks Dennis. -- Jens Axboe