From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbdLJQHq (ORCPT ); Sun, 10 Dec 2017 11:07:46 -0500 Received: from mout.web.de ([212.227.15.14]:56962 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbdLJQHn (ORCPT ); Sun, 10 Dec 2017 11:07:43 -0500 To: kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML From: SF Markus Elfring Subject: [PATCH] tty: isicom: Delete an error message for a failed memory allocation in load_firmware() Message-ID: Date: Sun, 10 Dec 2017 17:07:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:LbS/iF+LyuShYMqqy9vwRVKQ9S+3EcIVRmd8v/FfO1uDRyTMY4X lCEPgrlH94t0ZZ8HnOwAtV/ulQd5KVM3mwgWnx9obCRltLRsm/htY6rGbFHWtVaDwjou7aG 8Xhq0L1iZf4sVIaYcQVFj55hoO4rU5hIlj9vf8dDeTywiZhS25GK+w6liRQX/tCmiRdcoJC /UctG4GKvaK/1XV4UrjxA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Wvt2eigtqzk=:5wRKqrBdLP1waye/7yQoz9 5rO4u9U51EB61TTwY81ctsvcbnCKI7eLHQOIXnMvJiJwaQX+9spHicq5LxyGJ+1EitgjxXPeu E9uOUlR0YmD5G01K+WFx6G8+fLcb2NLMQCZwu0HGmO73LdoEVlhVN9XHC2JPCU/ijR5WblG49 vLqCUmOdWqQv/7S+7qt54XZqK8DGyUbIVSdlTnAb3O1rnv25sB9BZ6PFa4RCL8UnYFDBpcRJo dqxE1RGnPhGttvelgb2X9WBzJekgeT3GmEOeySdRBqFsKELWmTZhgfgr2NKf4iQcVzSB6ZSov QG7GsO0hvBby1606qU4L/mgVuE1InYzon4quYyohVri5AlqUIyu+hKmmiUJLH9Ph3drHQB/8I sbsHvAjXqeuiViAQqytqKhld5+b6EgSIJaHdp37k83hLWLb29pWWoXhVGwzt38a/qklRRPNyl nU/3OoEqNssPgpZRtOK8UngMYgpDgKTgkTJVtlezKZJ27OAOt71Wh09/LaWV4PU/YXK0emgJ/ V2/tfyhhaOMP2ogK/Wl5IIvAIROtNSKNpBOw3HCOKe/P+y2mDQdjrWDOvtk3FovizA8qE27E+ +kHki440J/xGT2N2cmHlAWsswyDQRo2waBUEO1mfQczwxmZIsCRzSQ/SNHZBfQK0WecvFbbhA 0chyUwpCKPdiKZcMqZJws7r1V4TXf8Po40F3oQ5vn9gcBdCFxfc9vsz8nXA/huFc92RtVAhw5 6ARjDCaEgjgGIYQHjmnZhS+V3n9kPQ7FKbviO3xU/FmS++NFcMizfIZZMNcRC1wpS6S5aymYg UQMg701SXPJxjw+Idiu/4OHqcWLoomJ/foMkPUPYO3sW84Ubz4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 10 Dec 2017 17:00:05 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/isicom.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c index ee7958ab269f..c087ebfe62fd 100644 --- a/drivers/tty/isicom.c +++ b/drivers/tty/isicom.c @@ -1482,11 +1482,9 @@ static int load_firmware(struct pci_dev *pdev, } data = kmalloc(word_count * 2, GFP_KERNEL); - if (data == NULL) { - dev_err(&pdev->dev, "Card%d, firmware upload " - "failed, not enough memory\n", index + 1); + if (!data) goto errrelfw; - } + inw(base); insw(base, data, word_count); InterruptTheCard(base); -- 2.15.1