From: Georgi Djakov <djakov@kernel.org>
To: Shaik Sajida Bhanu <sbhanu@codeaurora.org>,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
robh+dt@kernel.org
Cc: asutoshd@codeaurora.org, stummala@codeaurora.org,
vbadigan@codeaurora.org, rampraka@codeaurora.org,
sayalil@codeaurora.org, sartgarg@codeaurora.org,
rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org,
sibis@codeaurora.org, okukatla@codeaurora.org,
cang@codeaurora.org, pragalla@codeaurora.org,
nitirawa@codeaurora.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org
Subject: Re: [PATCH V1] arm64: dts: qcom: sc7180: bus votes for eMMC and SD card
Date: Thu, 10 Jun 2021 10:34:28 +0300 [thread overview]
Message-ID: <b1d108f1-75c1-87a7-a9de-3a004f56596e@kernel.org> (raw)
In-Reply-To: <1623309189-27943-1-git-send-email-sbhanu@codeaurora.org>
Hi Sajida,
Thank you for the patch!
On 10.06.21 10:13, Shaik Sajida Bhanu wrote:
> Updated bus votes for eMMC and Sd card.
The commit text should also give answer to the question "Why is this
patch necessary?". Do we need a Fixes: tag? The subject could be
improved too. Please check:
https://www.kernel.org/doc/Documentation/process/submitting-patches.rst
Thanks,
Georgi
>
> Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 295844e..1fce39d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -726,15 +726,15 @@
> opp-100000000 {
> opp-hz = /bits/ 64 <100000000>;
> required-opps = <&rpmhpd_opp_low_svs>;
> - opp-peak-kBps = <100000 100000>;
> - opp-avg-kBps = <100000 50000>;
> + opp-peak-kBps = <1800000 600000>;
> + opp-avg-kBps = <100000 0>;
> };
>
> opp-384000000 {
> opp-hz = /bits/ 64 <384000000>;
> - required-opps = <&rpmhpd_opp_svs_l1>;
> - opp-peak-kBps = <600000 900000>;
> - opp-avg-kBps = <261438 300000>;
> + required-opps = <&rpmhpd_opp_nom>;
> + opp-peak-kBps = <5400000 1600000>;
> + opp-avg-kBps = <390000 0>;
> };
> };
> };
> @@ -2685,15 +2685,15 @@
> opp-100000000 {
> opp-hz = /bits/ 64 <100000000>;
> required-opps = <&rpmhpd_opp_low_svs>;
> - opp-peak-kBps = <160000 100000>;
> - opp-avg-kBps = <80000 50000>;
> + opp-peak-kBps = <1800000 600000>;
> + opp-avg-kBps = <100000 0>;
> };
>
> opp-202000000 {
> opp-hz = /bits/ 64 <202000000>;
> - required-opps = <&rpmhpd_opp_svs_l1>;
> - opp-peak-kBps = <200000 120000>;
> - opp-avg-kBps = <100000 60000>;
> + required-opps = <&rpmhpd_opp_nom>;
> + opp-peak-kBps = <5400000 1600000>;
> + opp-avg-kBps = <200000 0>;
> };
> };
> };
>
next prev parent reply other threads:[~2021-06-10 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 7:13 [PATCH V1] arm64: dts: qcom: sc7180: bus votes for eMMC and SD card Shaik Sajida Bhanu
2021-06-10 7:34 ` Georgi Djakov [this message]
2021-06-14 11:37 ` sbhanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d108f1-75c1-87a7-a9de-3a004f56596e@kernel.org \
--to=djakov@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nitirawa@codeaurora.org \
--cc=okukatla@codeaurora.org \
--cc=pragalla@codeaurora.org \
--cc=rampraka@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sartgarg@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=sbhanu@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).