From: Rajendra Nayak <rnayak@codeaurora.org>
To: Sibi Sankar <sibis@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] soc: qcom: rpmhpd: Make power_on actually enable the domain
Date: Thu, 15 Jul 2021 17:54:21 +0530 [thread overview]
Message-ID: <b1e1cd90-f7fb-5284-26df-3496d560dea7@codeaurora.org> (raw)
In-Reply-To: <902f7665ab9045e87fb07f848b994316@codeaurora.org>
On 7/15/2021 5:46 PM, Sibi Sankar wrote:
> Hey Bjorn,
>
> Thanks for the patch.
>
> On 2021-07-03 08:24, Bjorn Andersson wrote:
>> The general expectation is that powering on a power-domain should make
>> the power domain deliver some power, and if a specific performace state
>
> s/performace/performance/
>
>> is needed further requests has to be made.
>>
>> But in contrast with other power-domain implementations (e.g. rpmpd) the
>> RPMh does not have an interface to enable the power, so the driver has
>> to vote for a particular corner (performance level) in rpmh_power_on().
>>
>> But the corner is never initialized, so a typical request to simply
>> enable the power domain would not actually turn on the hardware. Further
>> more, when no more clients vote for a performance state (i.e. the
>> aggregated vote is 0) the power domain would be turn off.
>>
>> Fix both of these issues by always voting for a corner with non-zero
>> value, when the power domain is enabled.
>>
>> The tracking of the lowest non-zero corner is performed to handle the
>> corner case if there's ever a domain with a non-zero lowest corner, in
>> which case both rpmh_power_on() and rpmh_rpmhpd_set_performance_state()
>> would be allowed to use this lowest corner.
>>
>> Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>>
>> Resending because the hunk in rpmhpd_update_level_mapping() was left in the
>> index.
>>
>> drivers/soc/qcom/rpmhpd.c | 18 ++++++++++++++----
>> 1 file changed, 14 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
>> index fa209b479ab3..76ea6b053ef0 100644
>> --- a/drivers/soc/qcom/rpmhpd.c
>> +++ b/drivers/soc/qcom/rpmhpd.c
>> @@ -30,6 +30,7 @@
>> * @active_only: True if it represents an Active only peer
>> * @corner: current corner
>> * @active_corner: current active corner
>> + * @enable_corner: lowest non-zero corner
>> * @level: An array of level (vlvl) to corner (hlvl) mappings
>> * derived from cmd-db
>> * @level_count: Number of levels supported by the power domain. max
>> @@ -47,6 +48,7 @@ struct rpmhpd {
>> const bool active_only;
>> unsigned int corner;
>> unsigned int active_corner;
>> + unsigned int enable_corner;
>> u32 level[RPMH_ARC_MAX_LEVELS];
>> size_t level_count;
>> bool enabled;
>> @@ -385,13 +387,13 @@ static int rpmhpd_aggregate_corner(struct rpmhpd
>> *pd, unsigned int corner)
>> static int rpmhpd_power_on(struct generic_pm_domain *domain)
>> {
>> struct rpmhpd *pd = domain_to_rpmhpd(domain);
>> - int ret = 0;
>> + unsigned int corner;
>> + int ret;
>>
>> mutex_lock(&rpmhpd_lock);
>>
>> - if (pd->corner)
>> - ret = rpmhpd_aggregate_corner(pd, pd->corner);
>> -
>> + corner = max(pd->corner, pd->enable_corner);
>> + ret = rpmhpd_aggregate_corner(pd, corner);
>> if (!ret)
>> pd->enabled = true;
>>
>> @@ -436,6 +438,10 @@ static int rpmhpd_set_performance_state(struct
>> generic_pm_domain *domain,
>> i--;
>>
>> if (pd->enabled) {
>> + /* Ensure that the domain isn't turn off */
>> + if (i < pd->enable_corner)
>> + i = pd->enable_corner;
>> +
>> ret = rpmhpd_aggregate_corner(pd, i);
>> if (ret)
>> goto out;
>> @@ -472,6 +478,10 @@ static int rpmhpd_update_level_mapping(struct
>> rpmhpd *rpmhpd)
>> for (i = 0; i < rpmhpd->level_count; i++) {
>> rpmhpd->level[i] = buf[i];
>>
>> + /* Remember the first non-zero corner */
>
> Shouldn't we be tracking the corner that
> corresponds to the first non-zero level
> instead?
Thats correct, thanks for spotting this, the first non-zero
corner is always 1 :)
>
>> + if (!rpmhpd->enable_corner)
>> + rpmhpd->enable_corner = i;
>> +
>> /*
>> * The AUX data may be zero padded. These 0 valued entries at
>> * the end of the map must be ignored.
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-07-15 12:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 0:54 [PATCH 0/2] soc: qcom: rpmhpd: Improve rpmhpd enable handling Bjorn Andersson
2021-07-03 0:54 ` [PATCH 1/2] soc: qcom: rpmhpd: Use corner in power_off Bjorn Andersson
2021-07-05 4:26 ` Rajendra Nayak
2021-07-05 5:06 ` Bjorn Andersson
2021-07-05 5:40 ` Rajendra Nayak
2021-07-07 4:49 ` Bjorn Andersson
2021-07-07 6:31 ` Rajendra Nayak
2021-07-07 15:48 ` Bjorn Andersson
2021-07-07 16:58 ` Dmitry Baryshkov
2021-07-08 0:21 ` Stephen Boyd
2021-07-08 4:35 ` Bjorn Andersson
2021-07-08 5:03 ` Rajendra Nayak
2021-07-08 6:51 ` Stephen Boyd
2021-07-15 10:40 ` Sibi Sankar
2021-07-03 0:54 ` [PATCH 2/2] soc: qcom: rpmhpd: Make power_on actually enable the domain Bjorn Andersson
2021-07-03 2:54 ` [RESEND PATCH " Bjorn Andersson
2021-07-08 0:23 ` Stephen Boyd
2021-07-08 0:25 ` Stephen Boyd
2021-07-14 9:22 ` Rajendra Nayak
2021-07-15 12:16 ` Sibi Sankar
2021-07-15 12:24 ` Rajendra Nayak [this message]
2021-08-12 13:21 ` Dmitry Baryshkov
2021-08-13 9:45 ` Ulf Hansson
2021-07-05 12:55 ` [PATCH 0/2] soc: qcom: rpmhpd: Improve rpmhpd enable handling Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1e1cd90-f7fb-5284-26df-3496d560dea7@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).