From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=LQxz=DO=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7049EC4363C
	for <linux-kernel@archiver.kernel.org>; Wed,  7 Oct 2020 18:44:51 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 165112173E
	for <linux-kernel@archiver.kernel.org>; Wed,  7 Oct 2020 18:44:51 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728198AbgJGSou (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 7 Oct 2020 14:44:50 -0400
Received: from smtprelay0111.hostedemail.com ([216.40.44.111]:37170 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1727293AbgJGSot (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Oct 2020 14:44:49 -0400
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
        by smtprelay05.hostedemail.com (Postfix) with ESMTP id C06281802915B;
        Wed,  7 Oct 2020 18:44:48 +0000 (UTC)
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-HE-Tag: edge71_3e0bdaf271d1
X-Filterd-Recvd-Size: 2066
Received: from XPS-9350.home (unknown [47.151.133.149])
        (Authenticated sender: joe@perches.com)
        by omf03.hostedemail.com (Postfix) with ESMTPA;
        Wed,  7 Oct 2020 18:44:47 +0000 (UTC)
Message-ID: <b1f15283f770c71923920fef8fc6c643433d1ef9.camel@perches.com>
Subject: Re: [PATCH v5] checkpatch: add new warnings to author signoff
 checks.
From:   Joe Perches <joe@perches.com>
To:     Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc:     linux-kernel-mentees@lists.linuxfoundation.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date:   Wed, 07 Oct 2020 11:44:46 -0700
In-Reply-To: <CABJPP5B_nscUwm4m+PySN67Cp=i1aR8KXKRuAf2YdAj_950j2Q@mail.gmail.com>
References: <20201007063315.41585-1-dwaipayanray1@gmail.com>
         <CABJPP5AEELQz0t2+34xYQOJ5e5nQzTUUU6UT8ZH0fqm-tacOmg@mail.gmail.com>
         <a2db6d34e964bd5ca65f59d1a536a61df71fc955.camel@perches.com>
         <CABJPP5B_nscUwm4m+PySN67Cp=i1aR8KXKRuAf2YdAj_950j2Q@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2020-10-08 at 00:08 +0530, Dwaipayan Ray wrote:
> On Wed, Oct 7, 2020 at 11:48 PM Joe Perches <joe@perches.com> wrote:
> > On Wed, 2020-10-07 at 12:08 +0530, Dwaipayan Ray wrote:
> > > On Wed, Oct 7, 2020 at 12:03 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> > > > The author signed-off-by checks are currently very vague.
> > > > Cases like same name or same address are not handled separately.
> > 
> > Likely now, the type should be changed from NO_AUTHOR_SIGN_OFF
> > to a single something else for all the other types of messages.
> > 
> > 
> Since BAD_SIGNOFF is being used for a different context, then
> probably BAD_AUTHOR_SIGNOFF.
>
> Should this work or anything else you have in mind?

That may be a bit too strong a wording as these aren't
significant/bad defects.

Maybe something like FROM_SIGNOFF_MISMATCH.

It's not anything that would reject the patch.

It's a pity type uses both SIGNOFF and SIGN_OFF.