From: David Hildenbrand <david@redhat.com>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>,
"Matthew Wilcox" <willy@infradead.org>
Cc: Aili Yao <yaoaili@kingsoft.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yangfeng1@kingsoft.com" <yangfeng1@kingsoft.com>,
"sunhao2@kingsoft.com" <sunhao2@kingsoft.com>,
Oscar Salvador <osalvador@suse.de>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH v5] mm/gup: check page hwposion status for coredump.
Date: Wed, 31 Mar 2021 09:05:06 +0200 [thread overview]
Message-ID: <b209732d-25ce-2974-4637-7c4fdb297fc3@redhat.com> (raw)
In-Reply-To: <20210331065341.GA28793@hori.linux.bs1.fc.nec.co.jp>
On 31.03.21 08:53, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Wed, Mar 31, 2021 at 07:07:39AM +0100, Matthew Wilcox wrote:
>> On Wed, Mar 31, 2021 at 01:52:59AM +0000, HORIGUCHI NAOYA(堀口 直也) wrote:
>>> If we successfully unmapped but failed in truncate_error_page() for example,
>>> the processes mapping the page would get -EFAULT as expected. But even in
>>> this case, other processes could reach the error page via page cache and
>>> __get_user_pages_locked() for them could return the hwpoisoned page.
>>
>> How would that happen? We check PageHWPoison before inserting a page
>> into the page tables. See, eg, filemap_map_pages() and __do_fault().
>
> Ah, you're right, that never happens. I misread the code.
> Thanks for correcting me.
>
I'm wondering if there is a small race window, if we poison a page while
inserting it.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-03-31 7:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 8:37 [PATCH] mm/gup: check page posion status for coredump Aili Yao
2021-03-17 9:12 ` David Hildenbrand
2021-03-18 3:15 ` Aili Yao
2021-03-18 3:18 ` [PATCH v2] " Aili Yao
2021-03-18 4:46 ` [PATCH] " Matthew Wilcox
2021-03-18 5:34 ` Aili Yao
2021-03-19 2:44 ` [PATCH v3] " Aili Yao
2021-03-20 0:35 ` Matthew Wilcox
2021-03-22 3:40 ` Aili Yao
2021-03-22 11:33 ` [PATCH v5] mm/gup: check page hwposion " Aili Yao
2021-03-26 14:09 ` David Hildenbrand
2021-03-26 14:22 ` David Hildenbrand
2021-03-31 1:52 ` HORIGUCHI NAOYA(堀口 直也)
2021-03-31 2:43 ` Aili Yao
2021-03-31 4:32 ` HORIGUCHI NAOYA(堀口 直也)
2021-03-31 6:44 ` David Hildenbrand
2021-03-31 7:07 ` Aili Yao
2021-04-01 2:31 ` Aili Yao
2021-04-06 2:23 ` [PATCH v6] mm/gup: check page hwpoison status for memory recovery failures Aili Yao
2021-04-06 2:41 ` [PATCH v7] " Aili Yao
2021-04-07 1:54 ` HORIGUCHI NAOYA(堀口 直也)
2021-04-07 7:48 ` Aili Yao
2021-05-10 3:13 ` Aili Yao
2021-03-31 6:07 ` [PATCH v5] mm/gup: check page hwposion status for coredump Matthew Wilcox
2021-03-31 6:53 ` HORIGUCHI NAOYA(堀口 直也)
2021-03-31 7:05 ` David Hildenbrand [this message]
2021-03-18 8:14 ` [PATCH] mm/gup: check page posion " David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b209732d-25ce-2974-4637-7c4fdb297fc3@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=sunhao2@kingsoft.com \
--cc=willy@infradead.org \
--cc=yangfeng1@kingsoft.com \
--cc=yaoaili@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).